From patchwork Tue Jul 7 11:46:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5b2t5rWpKFJpY2hhcmQp?= X-Patchwork-Id: 11648477 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F39B92A for ; Tue, 7 Jul 2020 11:48:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 489FF2073E for ; Tue, 7 Jul 2020 11:48:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XWxRlMRl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=oppoglobal.onmicrosoft.com header.i=@oppoglobal.onmicrosoft.com header.b="p0ozcwr5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 489FF2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oppo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=vWgLiCIYERceThx4QkT0rlipNwCAB6hd0HEmtCHLkOE=; b=XWxRlMRlP9G8S4Cg/j16paiCRT pSBXJ0Lt4/nbeIPLhp6ljuEMJRPfdcrYYAiPHkgAkBPs3W19bZRCjyyP4RrA8ajkAztHzzYvq/cRC m/L22Ng7txe1VBO4HzgOSa7aHNtuh67BtK4TKOLXhZlt4SOIn5sV5qlLpyWlkcc5L3aRYlEkCDGBc k3bxyBEUykfT9hznqKHFAqyqS1OTEGLiU0w2X+PPDy/nAFh6/K9EjXG/Cr97JHVPMqErSd4gN0es6 FOWeEP09QCOkJ1RNPIIlyoqoLOy3eZX+nGT5fyHRB3gdoAiC7ZTzdPb3o38qgWoxQoV0JQjU8m5WF GkSdU5CA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsm3c-0000aL-An; Tue, 07 Jul 2020 11:46:40 +0000 Received: from mail-eopbgr1300055.outbound.protection.outlook.com ([40.107.130.55] helo=APC01-HK2-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsm3Y-0000Yr-6r for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 11:46:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnRg9yh1CVHY7Pc15VYYWfZt8+XEHsJlkjG4jNqh5QnDBC2ZZrbjpos7vtQj7QYGIKGHazLm6cJrT2bq0O0I8Wy3s2C4gaR8BDx6CkLsIqqYNvexTvnrGDA8qSX4ZCJjyjmn10kEKK4PlLAAAq7sV97Ei/kOe9vy/9nOCbjmFNcOfP56IqkJW4vs/sGYwXLgoboNRaFxJ4uuYTxG1Gee39nKNtpZq9IQkqwlfe882rYsdiX7Of/KjwxC7QYHDz/tnAc4TM3CHYVrpOyY6bLah0mMMr2sJduBem4s8sF2XcGbK7ONEA+9ASoEyiohutbZvRmIoGsVG90ofj9wdshntw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9MsM2h7wNcto44n6MpPc1JPDWoxMT4UxiINkCMcq/o=; b=IBn7ISaGx6RegsumFIAGEIfvvHn8EXDi66H0TeFk6hgexgy1uDIjZLM5D3dNO2/dMXMutyLceVvQ4aHKWlX+DVCS0E/vEZBxWLrcp799z0uUEqPgwJhaaME/zxpLnC4tNtf3ejuhPyukp1rweVJ5qNqL7oww4Lad2hxAlePxo934Ddw0LhbkiMotOA9NJzSKZ1wxaPiC80dw7RJBG26w5hIaNqPH7LUQDA0RVVRxOhy0+GIwfr9G6ifKKmdMpEp9Kgh/yNIQktbQpWwdfBDR8Y5zhjzI6t2ypSEg/u0oPHM1XzZABx4EvldWAo5+hTKiDknCdVDjb6ak9Rjz4HcUyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppoglobal.onmicrosoft.com; s=selector1-oppoglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9MsM2h7wNcto44n6MpPc1JPDWoxMT4UxiINkCMcq/o=; b=p0ozcwr57L9Z6+vws9w0UoLQnr0eMg7cmektQ2C2xj8dSTgSpdDh6aTEbad2bA4/9SzNPLwygPBDVEEWI1j2RAaHGwu2nXMlTTzs/+sWoANom8935ss76MrCAfATmRIAnRK/CozUL2mUx6kj1BqD84JiTzZy09ICYO829IZJPnE= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=oppo.com; Received: from HKAPR02MB4291.apcprd02.prod.outlook.com (2603:1096:203:d3::12) by HK0PR02MB3475.apcprd02.prod.outlook.com (2603:1096:203:79::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Tue, 7 Jul 2020 11:46:26 +0000 Received: from HKAPR02MB4291.apcprd02.prod.outlook.com ([fe80::d4d8:820c:6e00:69d2]) by HKAPR02MB4291.apcprd02.prod.outlook.com ([fe80::d4d8:820c:6e00:69d2%7]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 11:46:26 +0000 From: Peng Hao To: catalin.marinas@arm.com, will@kernel.org Subject: [PATCH] arm64/module-plts: Consider the special case where plt_max_entries is 0 Date: Tue, 7 Jul 2020 07:46:08 -0400 Message-Id: <20200707114608.24197-1-richard.peng@oppo.com> X-Mailer: git-send-email 2.18.4 X-ClientProxiedBy: HK2PR0401CA0011.apcprd04.prod.outlook.com (2603:1096:202:2::21) To HKAPR02MB4291.apcprd02.prod.outlook.com (2603:1096:203:d3::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from PC-Hyman.adc.com (58.252.5.74) by HK2PR0401CA0011.apcprd04.prod.outlook.com (2603:1096:202:2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend Transport; Tue, 7 Jul 2020 11:46:25 +0000 X-Mailer: git-send-email 2.18.4 X-Originating-IP: [58.252.5.74] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 673dba95-0614-47c2-f603-08d8226b6154 X-MS-TrafficTypeDiagnostic: HK0PR02MB3475: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-Forefront-PRVS: 0457F11EAF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: muJpT4XAv6eB2XBYGf97DQDVLNV36KsU2gYBMs68oCIldVPdf2uUXnof7RiA/PQjOmw87dWMLoog2fc+d/NkgdhPFAMYGjWcvyFs8a2H5Zh64XsCtyYG42bhRqwJY/yV6Ho9nLDQbBYF6UEf6B4kAO3O2X7j5wzYB79CwgM09YsenMSD018ILO+vo25ym+ynFX5oXKxASLLsolWne0X7Z8Gdm6XcQri0il1g9A+mjCj9DFaGBdEFzRKo32emZvVZHW1JGdc6P58eA3sXLcbSu/KE4jws4YvAEfqrYJB5d2eC1ZmZ4n5Saus/BQszvJUJqj+024x2sLGw6SyyWivST7Wcq5hDibz8p3s8OXDuyGCDZmfEhNRG5MXrnDjt/u/ho6u5ZJXXcjN5z0APdM+dMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HKAPR02MB4291.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(136003)(376002)(39860400002)(396003)(346002)(1076003)(6512007)(107886003)(4744005)(2616005)(316002)(956004)(66946007)(52116002)(6506007)(6666004)(66476007)(66556008)(83380400001)(8676002)(2906002)(86362001)(5660300002)(36756003)(6486002)(26005)(186003)(8936002)(478600001)(16526019)(4326008)(1670200006)(11606004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 8+DAgTHE+x1OWvf1vImcmLEw1QRoLEC952sFgIEUsLQZGKCAwZw2LJoZmXuLhAVHbXv4UXj8Qir1HG+Cpm5NBO2zqkIQZ2ENnI0vXmubb2D8CorcQEeHd/hari9DIxKcbcUT6F9qYVe0Gb7l/9G6aO5V/vPq0H6VO9K0dTQghIPv3jGPJpiQzBffACoOQYiN56fAaQpkBWU3NxYU2dHlg2l22EY9AXrOul1EKEs6wzgTMACiP1swMo21fLFWFDVvXhbDSly9RgDqYPT2cu5A1a1zDsccYA0dcFqAdlszRHHMGLQ7jbQkYin6rXVfy8sxiUsXAY2laIQaPoXUEnukM4TabrsLta3TYl5VdVsUldhD51FNpqLbas+6fAbqzotjXs2WHTZ6JSR+ybBA6svdp1rJzPYGinPvRQUsSiWwgLvbaG5BTdjLDIJug9qCzJKvUTGxHw8xWHXj1L4tYLtUar4O1Zl0R3gCUW9VRQeHp7E= X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 673dba95-0614-47c2-f603-08d8226b6154 X-MS-Exchange-CrossTenant-AuthSource: HKAPR02MB4291.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2020 11:46:26.5675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7CypAJZm9zK5Ypr7Vf1N5RJNLjmJGpxDumyrlQR1mqSCZXy57SbhncGCeEkWMNFPPnAVCmyrh3fJ2WxUQLTwPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR02MB3475 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_074636_258328_D368AE0C X-CRM114-Status: UNSURE ( 7.47 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [40.107.130.55 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.130.55 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Hao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If plt_max_entries is 0, a warning is triggered. WARNING: CPU: 200 PID: 3000 at arch/arm64/kernel/module-plts.c:97 module_emit_plt_entry+0xa4/0x150 Signed-off-by: Peng Hao --- arch/arm64/kernel/module-plts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/module-plts.c b/arch/arm64/kernel/module-plts.c index 65b08a74aec6..1868c9ac13f2 100644 --- a/arch/arm64/kernel/module-plts.c +++ b/arch/arm64/kernel/module-plts.c @@ -79,7 +79,8 @@ u64 module_emit_plt_entry(struct module *mod, Elf64_Shdr *sechdrs, int i = pltsec->plt_num_entries; int j = i - 1; u64 val = sym->st_value + rela->r_addend; - + if (pltsec->plt_max_entries == 0) + return 0; if (is_forbidden_offset_for_adrp(&plt[i].adrp)) i++;