diff mbox series

arm64: stacktrace: Move export for save_stack_trace_tsk()

Message ID 20200710182402.50473-1-broonie@kernel.org (mailing list archive)
State Mainlined
Commit 0de674afe83cb23676ec391470251aaa9700f21a
Headers show
Series arm64: stacktrace: Move export for save_stack_trace_tsk() | expand

Commit Message

Mark Brown July 10, 2020, 6:24 p.m. UTC
Due to refactoring way back in bb53c820c5b0f1 ("arm64: stacktrace: avoid
listing stacktrace functions in stacktrace") the EXPORT_SYMBOL_GPL() for
save_stack_trace_tsk() is at the end of __save_stack_trace() rather than
the function it exports. Move it to the expected location.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/kernel/stacktrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Deacon July 13, 2020, 8:42 p.m. UTC | #1
On Fri, Jul 10, 2020 at 07:24:02PM +0100, Mark Brown wrote:
> Due to refactoring way back in bb53c820c5b0f1 ("arm64: stacktrace: avoid
> listing stacktrace functions in stacktrace") the EXPORT_SYMBOL_GPL() for
> save_stack_trace_tsk() is at the end of __save_stack_trace() rather than
> the function it exports. Move it to the expected location.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm64/kernel/stacktrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Will Deacon <will@kernel.org>

Will
diff mbox series

Patch

diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 139679c745bf..2dd8e3b8b94b 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -199,12 +199,12 @@  static noinline void __save_stack_trace(struct task_struct *tsk,
 
 	put_task_stack(tsk);
 }
-EXPORT_SYMBOL_GPL(save_stack_trace_tsk);
 
 void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
 {
 	__save_stack_trace(tsk, trace, 1);
 }
+EXPORT_SYMBOL_GPL(save_stack_trace_tsk);
 
 void save_stack_trace(struct stack_trace *trace)
 {