| Message ID | 20200713130509.20105-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9c852ad98f2c65bca263cf53d46b3eb851713b0e |
| Headers | show |
| Series | [v3,1/2] ARM: dts: imx6q-tbs2910: Add an mdio node | expand |
On 13.07.20 15:05, Fabio Estevam wrote: > imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4. > > The AR8035 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin. > > Improve the Ethernet representation by adding an mdio node with such > information. > > This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now > expects the 'qca,clk-out-frequency' property to be passed via > device tree. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> As for v2: This works, describes the hardware correctly, and fixes ethernet problems in U-Boot. Reviewed-by: Soeren Moch <smoch@web.de> Tested in U-Boot and linux-5.7: Tested-by: Soeren Moch <smoch@web.de> Thanks, Soeren > --- > Changes since v2: > - None. Only reorded the patches. > > arch/arm/boot/dts/imx6q-tbs2910.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts > index bfff87ce2e1f..1f34028c6397 100644 > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts > @@ -100,7 +100,18 @@ > pinctrl-0 = <&pinctrl_enet>; > phy-mode = "rgmii-id"; > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > + phy-handle = <&phy>; > status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy: ethernet-phy@4 { > + reg = <4>; > + qca,clk-out-frequency = <125000000>; > + }; > + }; > }; > > &hdmi {
On Mon, Jul 13, 2020 at 10:05:08AM -0300, Fabio Estevam wrote: > imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4. > > The AR8035 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin. > > Improve the Ethernet representation by adding an mdio node with such > information. > > This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now > expects the 'qca,clk-out-frequency' property to be passed via > device tree. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts index bfff87ce2e1f..1f34028c6397 100644 --- a/arch/arm/boot/dts/imx6q-tbs2910.dts +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts @@ -100,7 +100,18 @@ pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + phy-handle = <&phy>; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + phy: ethernet-phy@4 { + reg = <4>; + qca,clk-out-frequency = <125000000>; + }; + }; }; &hdmi {
imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4. The AR8035 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin. Improve the Ethernet representation by adding an mdio node with such information. This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now expects the 'qca,clk-out-frequency' property to be passed via device tree. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Changes since v2: - None. Only reorded the patches. arch/arm/boot/dts/imx6q-tbs2910.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)