[v30,02/16] leds: lp5523: Fix various formatting issues in the code

Commit Message

Dan Murphy July 13, 2020, 3:45 p.m. UTC

Fix checkpatch errors and warnings for the LP5523.c device
driver.

Acked-by: Pavel Machek <[e-mail]>
Acked-by: Jacek Anaszewski <[e-mail]>
Signed-off-by: Dan Murphy <[e-mail]>
---
 drivers/leds/leds-lp5523.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Marek Behún July 15, 2020, 1:20 p.m. UTC | #1

On Mon, 13 Jul 2020 10:45:30 -0500
Dan Murphy <[e-mail]> wrote:

> Fix checkpatch errors and warnings for the LP5523.c device
> driver.
> 
> Acked-by: Pavel Machek <[e-mail]>
> Acked-by: Jacek Anaszewski <[e-mail]>
> Signed-off-by: Dan Murphy <[e-mail]>
> ---
>  drivers/leds/leds-lp5523.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-) 

Reviewed-by: Marek Behún <[e-mail]>

Patch

diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index d0b931a136b9..8518de957b48 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -23,13 +23,13 @@ 
 
 #define LP5523_PROGRAM_LENGTH		32	/* bytes */
 /* Memory is used like this:
-   0x00 engine 1 program
-   0x10 engine 2 program
-   0x20 engine 3 program
-   0x30 engine 1 muxing info
-   0x40 engine 2 muxing info
-   0x50 engine 3 muxing info
-*/
+ * 0x00 engine 1 program
+ * 0x10 engine 2 program
+ * 0x20 engine 3 program
+ * 0x30 engine 1 muxing info
+ * 0x40 engine 2 muxing info
+ * 0x50 engine 3 muxing info
+ */
 #define LP5523_MAX_LEDS			9
 
 /* Registers */
@@ -326,7 +326,7 @@  static int lp5523_update_program_memory(struct lp55xx_chip *chip,
 					const u8 *data, size_t size)
 {
 	u8 pattern[LP5523_PROGRAM_LENGTH] = {0};
-	unsigned cmd;
+	unsigned int cmd;
 	char c[3];
 	int nrchars;
 	int ret;
@@ -468,6 +468,7 @@  static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)
 static void lp5523_mux_to_array(u16 led_mux, char *array)
 {
 	int i, pos = 0;
+
 	for (i = 0; i < LP5523_MAX_LEDS; i++)
 		pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i));
 
@@ -506,7 +507,7 @@  static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
 	if (ret)
 		return ret;
 
-	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8));
+	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8));
 	if (ret)
 		return ret;