From patchwork Tue Jul 14 11:15:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662419 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 16F8613B6 for ; Tue, 14 Jul 2020 11:20:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E484121D90 for ; Tue, 14 Jul 2020 11:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GdY8o/f4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="olMroX2n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E484121D90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qx+VeX7vPRx/UuFoYCAweC0en9fveoTcKlczjdJOIWE=; b=GdY8o/f4i0cvXns+J8RF/gXzR dFhFqdtLwcuwPGBU7Nhc/HeY6mQi7S7xuSTBVDbHPhQHJtJVoWm073ZKekS49+53XIFmQfeDEMa9P FAG8KlDQ1sMKKAWXMI6Q1sDl+IbeKeAs5HUFliBilp4b6GO/whQfwetbp6oUfU2fFsI95p+Z60dSd XOSCy0nAei/Bn+jkvHV0q6zb3Y7C2EoDtkPXyUJ47lg32ecMeBhGxISIq7AgLCA+q6a4PLMK9UOjk 8tPw69zyyigPWeU7+nxv69oGLE5tC2lBNKi5rEDCZjuWLl1ZmIhITTj7+4KJIGJ19t5ZjeBfPrVvz DgtJAnApQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvIxD-0004pz-Jr; Tue, 14 Jul 2020 11:18:31 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvIux-0003aF-Lw for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 11:16:13 +0000 Received: by mail-wm1-x342.google.com with SMTP id f139so4995655wmf.5 for ; Tue, 14 Jul 2020 04:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=olMroX2nvIY5Lf+mJdh7YdFYN9DJVM3DML7ddb9rOUmNTds3C+m2JdC3mqOc4y2yki oCjN/ROWc7AHqc9tDEJzhS48Ft6N8WDIfr4nT2lTE5jdLWQGIWrolpNjO+lPcicdCRRM 2fCsqXPM7bJUnvwrgFNVo7ICmUoZdIFs0+zJzOFi3XIgI9grTk89B6Pv4TQQAvkhtRye 9sjSmijV4C2Z3rQ8tSb74WzoWGcSTqF9z7JoxwTfy5DhX28xoARq2ihF4ykZe7GW8r58 nDxZdTjaN05xW+eeHH3pFOqwpav7WW2J+QyIHz+GahF3UcEzGl7obV8i3hDK+YXlBs7R Pf0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=DcAkljycn+O939a1AuEjGKEc/JdiZ1F+uGQKH1OzLiX4c2be67WzgUH3Kbl/ybYEdC twzA7sXUrLa9XunLhz6urYiiqJL0d1rSwTeU7hAugbCyGet1/oDASSoTNYAP5SRcXtIy 5ExhQD7cCNOGvqYYu1ZcOg6ocsDGQvHQooRajHAcH6PpEaRsIDWGM/Pi8UFSZCylQa/o KjpJfMj6+3S4qiNxUGqHsZfqmMjWF8CdrIWj45049wIwRXyLzj800Rmh7JIXvu/eWo4x 7cRWFDmNw1wksl3dA4OIUt9e3jjp9kPPvTJWcCskprwZhZoUEwYpCaRA7Wr21AS6ipp9 BBEg== X-Gm-Message-State: AOAM532U5JicLrhDOHRaEger+oyl97oNjW9vSJfOiQ36jKb1LmqkoNBq OGoKb8x8I2uZHjQGFgfz5m+yCw== X-Google-Smtp-Source: ABdhPJzfCBA237+MDiPPiC6gnBUiuuivn5CvYJKDoBxN2PB52EY3xNb72wTKP7tCyZ9qJUnt4SpQXw== X-Received: by 2002:a1c:7209:: with SMTP id n9mr3892120wmc.150.1594725369516; Tue, 14 Jul 2020 04:16:09 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:08 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Subject: [PATCH 17/17] dma: ioat: dma: Fix some parameter misspelling and provide description for phys_complete Date: Tue, 14 Jul 2020 12:15:46 +0100 Message-Id: <20200714111546.1755231-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_071611_836112_B53DB750 X-CRM114-Status: GOOD ( 10.62 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Jiang , Leonid Ravich , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/dma/ioat/dma.c:202: warning: Function parameter or member 'ioat_chan' not described in 'ioat_update_pending' drivers/dma/ioat/dma.c:202: warning: Excess function parameter 'ioat' description in 'ioat_update_pending' drivers/dma/ioat/dma.c:465: warning: Function parameter or member 'ioat_chan' not described in 'ioat_check_space_lock' drivers/dma/ioat/dma.c:465: warning: Excess function parameter 'ioat' description in 'ioat_check_space_lock' drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'ioat_chan' not described in '__cleanup' drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'phys_complete' not described in '__cleanup' drivers/dma/ioat/dma.c:591: warning: Excess function parameter 'ioat' description in '__cleanup' Cc: Dave Jiang Cc: Leonid Ravich Signed-off-by: Lee Jones --- drivers/dma/ioat/dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index fd782aee02d92..a814b200299bf 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -193,7 +193,7 @@ void ioat_issue_pending(struct dma_chan *c) /** * ioat_update_pending - log pending descriptors - * @ioat: ioat+ channel + * @ioat_chan: ioat+ channel * * Check if the number of unsubmitted descriptors has exceeded the * watermark. Called with prep_lock held @@ -457,7 +457,7 @@ ioat_alloc_ring(struct dma_chan *c, int order, gfp_t flags) /** * ioat_check_space_lock - verify space and grab ring producer lock - * @ioat: ioat,3 channel (ring) to operate on + * @ioat_chan: ioat,3 channel (ring) to operate on * @num_descs: allocation length */ int ioat_check_space_lock(struct ioatdma_chan *ioat_chan, int num_descs) @@ -585,7 +585,8 @@ desc_get_errstat(struct ioatdma_chan *ioat_chan, struct ioat_ring_ent *desc) /** * __cleanup - reclaim used descriptors - * @ioat: channel (ring) to clean + * @ioat_chan: channel (ring) to clean + * @phys_complete: zeroed (or not) completion address (from status) */ static void __cleanup(struct ioatdma_chan *ioat_chan, dma_addr_t phys_complete) {