From patchwork Wed Jul 15 08:26:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11664455 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 561A0913 for ; Wed, 15 Jul 2020 08:46:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F5262064C for ; Wed, 15 Jul 2020 08:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Co3y9MT0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wdxG8jLe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F5262064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+5FQB90Lhg8rIezZZ1U007MPGyuEZAQv4IO5VLSCle0=; b=Co3y9MT05xeI8f7Nhw5QH5sUq 9I8aHNf1wGaaFk4wvDfcYLtihtHFuuIBBw0QfYgmYXSe5jbGjar+xTEm86g93qafVzxOZfrrXTJSn Iimd0tVCQBqimu1/rX8/kjDOOtjuLDRwm1BSey32F79C2k+kiduoDPWLhO9FTWcz7cn3PpJBv5D/3 44YQoPAS4jKBK4q64Qk1H0H8OaXE7xuQjhykJsZuzlUxkf0N3LU7TJpglT450m8ksbIqr5uKk66uV RszSPtSRWwgdfL24DlQMzTELY5wwyeGactpZVsus2SFWPA+Vk4EqyU6X7W6jlzKFUgpfnp6FI4rHS dqQ4d6zDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvcls-0003tl-Ug; Wed, 15 Jul 2020 08:28:09 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvckZ-0003Ks-IN for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 08:26:50 +0000 Received: by mail-wr1-x442.google.com with SMTP id f2so1466101wrp.7 for ; Wed, 15 Jul 2020 01:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Z0fv79A73/vZIqM6ECnqpdpU/+7K2Y0w7fARWedt1c=; b=wdxG8jLedDYRfjs4gGzseOHpJxQaqy1oTFNhn/v43wZILfD7sUfWOlTF/WfpZ53GiT 9oirELAFbfOr4p5MsvB+3S3+PtP7e/IqharXV5TfUubJv6rBsfC9LqbdjWCx3fsWArRs RN3YAggQmoJk6eGn/MiyEbYw3IQ0k4T1WmIM+5/iLbtAJYlKiflIyr5p2Jtis7DbFJlz l+3GYbFdxmaVQCDR3DqZ7fiLFedXA2147Ou9CguKQ4q7pNY/y7oT+rcs2qaXJju7JgkL YgJfJG1bNq9KJ6W7Mt551x+CpJvCFlviz24zy1H4Bb9SL4Xv68oacZ7TTVxXCoVhg5mE Af6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Z0fv79A73/vZIqM6ECnqpdpU/+7K2Y0w7fARWedt1c=; b=guYO+BkeCSRcc3CJWOdlutrC4FE+LZL8WUzCKBZINqBIYMjIjxAXxVX5u+uwNhjgZQ +FZj/sH3Cp3mAOCVTerKl+ax6VkgT3QOFzJw7uQa9NKrY7Gzd24B9qZBmAleDsSH8q5x bLkI21kHh5Z2OT5MAcX2rziD2TsYTcWbRuVG1Rgf6fE4BhHYp49dxkNYoORjspe0MWlh OrE9WBDc1/3j7VwLrvw5IaX+/oz5+tAZwt6+gcp2ySc7lP+o+MToGlr5iU4yS21/mS+2 vbKnENgmWFd8f1hRLFdyglnUTIhClog4ZGb7bkBHuWjIkFDMdby9NqRcbHiqVE02eRjL 80uw== X-Gm-Message-State: AOAM5306i4hvx6Gm5H0DOpUdH6MCJJnPohwTR64PROL0bwX09kwl28Gr 7o7HJPAW3wHtJfkDEIzE0HOkfA== X-Google-Smtp-Source: ABdhPJxYpuDnFCKTJN9z/Su7SsjnFEtm4WYtkojHvEEbT9vOYYaxPZnzu+/urdXDpBhf2vcZO8Fd6Q== X-Received: by 2002:a5d:5084:: with SMTP id a4mr10347220wrt.191.1594801606598; Wed, 15 Jul 2020 01:26:46 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id h13sm2400361wml.42.2020.07.15.01.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 01:26:46 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: [PATCH v2 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Date: Wed, 15 Jul 2020 09:26:28 +0100 Message-Id: <20200715082634.3024816-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715082634.3024816-1-lee.jones@linaro.org> References: <20200715082634.3024816-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_042648_568125_7AE8A018 X-CRM114-Status: GOOD ( 14.89 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Repair problems with formatting and missing attributes/parameters, and demote header comments which do not meet the required standards applicable to kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_lpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_gpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'policy' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:182: warning: Function parameter or member 'i' not described in 'idx_to_pstate' drivers/cpufreq/powernv-cpufreq.c:201: warning: Function parameter or member 'pstate' not described in 'pstate_to_idx' drivers/cpufreq/powernv-cpufreq.c:670: warning: Function parameter or member 't' not described in 'gpstate_timer_handler' drivers/cpufreq/powernv-cpufreq.c:670: warning: Excess function parameter 'data' description in 'gpstate_timer_handler' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 068cc53abe320..2e5a8b8a4abaa 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -64,13 +64,14 @@ * highest_lpstate_idx * @last_sampled_time: Time from boot in ms when global pstates were * last set - * @last_lpstate_idx, Last set value of local pstate and global - * last_gpstate_idx pstate in terms of cpufreq table index + * @last_lpstate_idx: Last set value of local pstate and global + * @last_gpstate_idx: pstate in terms of cpufreq table index * @timer: Is used for ramping down if cpu goes idle for * a long time with global pstate held high * @gpstate_lock: A spinlock to maintain synchronization between * routines called by the timer handler and * governer's target_index calls + * @policy: Associated CPUFreq policy */ struct global_pstate_info { int highest_lpstate_idx; @@ -170,7 +171,7 @@ static inline u8 extract_pstate(u64 pmsr_val, unsigned int shift) /* Use following functions for conversions between pstate_id and index */ -/** +/* * idx_to_pstate : Returns the pstate id corresponding to the * frequency in the cpufreq frequency table * powernv_freqs indexed by @i. @@ -188,7 +189,7 @@ static inline u8 idx_to_pstate(unsigned int i) return powernv_freqs[i].driver_data; } -/** +/* * pstate_to_idx : Returns the index in the cpufreq frequencytable * powernv_freqs for the frequency whose corresponding * pstate id is @pstate. @@ -660,7 +661,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) /** * gpstate_timer_handler * - * @data: pointer to cpufreq_policy on which timer was queued + * @t: Timer context used to fetch global pstate info struct * * This handler brings down the global pstate closer to the local pstate * according quadratic equation. Queues a new timer if it is still not equal