From patchwork Fri Jul 17 13:54:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670417 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 26C7A13B1 for ; Fri, 17 Jul 2020 13:57:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2ECD20717 for ; Fri, 17 Jul 2020 13:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aXQiypch"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cCC6wwWl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2ECD20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GVuP6AXbVt/SZoDgqaMe06wiv0/4v/0XOEqVhuoSHm8=; b=aXQiypchWi0KVQSj0VrLBBalI wm3bsKigl01mV5T5sJbNGmreQ4o5YdugZjg6OfsJW3W5th6qWE4kq7ynjxABpsAcJw6B8dscEpF6X eT3P6ns7t4YrCHPzvegJbXAdKoygkKMQBdwp/PZeUrxzIqTq/Ef+15LAN8CBOznA0iZ25fHi8Kt/6 Lxhh+pVT3bnrYHznCq7kpdCQkLW60FDAPUPawgfOx3ULf2ZpMa5NmKB+u14JvtfMWgpJRphrlJjYp 4OOOcq944L+QSzD4pnVmd7c2qHUcLMwvU9O1Af28Wii6zE5pf9LbIn7Y6PSlkoGCif3C+q7i+ww4/ ToW10zRHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQpo-0003DP-6j; Fri, 17 Jul 2020 13:55:32 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQov-0002tQ-Ew for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id f139so17178367wmf.5 for ; Fri, 17 Jul 2020 06:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=cCC6wwWlQpTMveu1qLqD9irne79EY5ETXeh1rAvAAmH+LbiFyUjRk1ScIyrfmwefTv mFH+Dn3v/+xPUHoIWVWnpdkrm8IZAwwrC0nGV6nJHAUPKTjea9YuyLEZQwc1IJAswX6+ tCXEHvtE1nHhDMPzh2+JAiQX+k+oxlOF0rSb1BHirgI+fTnJa1Wag/CmnsEhB2k4FQei IuVXnlndn2vb2xncG+l0JMF/aakBraFwN6jUo0NHQUI1LLX0qof6/3e3YtpgKX0gUI4o sBKrEHsK4I3F+qIti6r6RGX+i+V2MWy7R7rwXBmQH2TfDvHmoPTS3FPp8isAlmk2K3fI VMLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=OA+0cHhk8wVIFmnM9WbWHB+qJt6KVXVoerdsdPVPvQUhz0KkW5MltkRHz4Qn7Ap/Jl KPWxhhz0FfPQll0akO/aSEd7nMVe95imfPz8bO8kJg5AxMexannAY8qEV3qVlNPbC4hK 9knNqWKufVKpkzLuLtio5VXgKLRPPgwpCbbx06hnQ4CLGXMt+RKLaLiVIehx65fdDJRj FSzhWTdz96/xrbrFpE10NiZUEpaWUDtwTEp6Saf5jcIlpeHPj+jypsOcAt8lFtQp1qax h77kd80I6f74jxOcu5O5TkvO7Wkwj3KdINOxg+etW1OOdfKmpdmcnxZQHmR+PSIvrnZY Ec5w== X-Gm-Message-State: AOAM531I4GQmacG4YzL0iaBxPv6mQz1ZbhSnpAc69r2TJbgg2HCMXPQT Ayp84sCxL+yhoNmylVir6EKqpw== X-Google-Smtp-Source: ABdhPJwcTbAJHeWet+0yZMRNf1B5uWVO3GrnOII6C92tRowqv4TTCeJPT7QC54S41JczZLvDokTPCg== X-Received: by 2002:a1c:2d0c:: with SMTP id t12mr9259723wmt.43.1594994076272; Fri, 17 Jul 2020 06:54:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:35 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Date: Fri, 17 Jul 2020 14:54:19 +0100 Message-Id: <20200717135424.2442271-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095437_549800_A386B70E X-CRM114-Status: GOOD ( 11.24 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , linux-kernel@vger.kernel.org, Sureshkumar Relli , linux-spi@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Sureshkumar Relli Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency.