From patchwork Fri Jul 17 13:54:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670427 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D730B13B1 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF58E20717 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2twAuKVN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CLcRog2e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF58E20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T9FfHxkMs+ZsC+4fqRbsz213O0o7WMv+4BV6ieknnas=; b=2twAuKVN6LftpbMKiA+RmZS5U KMJTF69tYElxMJ995+yWx1HTGnmsES0SRwSPVtOtR5QTUJ5i8O1Lm4hs5LgcrqEsv1ocOycqC9ih5 oekGHz5FUjI3ni58SS61N+Ve6+X5nOAQbmzDOAuIhTep4fvzk2+UVf4+ngsLNnh4ueFsH8QNYy24l IOSds08q98K08FexMsdaIMg0Gdf32oSj1jlDETEQLpvEmjNJyah24op9W0agCP8Zek4CL9sNnRWLT DupsRn23/NEz5wNBpW/1YQwIZdfIygApel2n6EFiDdTgDc6IxnCUl6HSBxNTwKisFNtt0LAdG693w kQAEs3LCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqL-0003WV-R3; Fri, 17 Jul 2020 13:56:05 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQox-0002uH-2v for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:40 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so17178482wmf.5 for ; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=CLcRog2efhriOmziPd49uvqHp4X3kgn1MMhEVojt9mJGnBLfyFuKfUqJx5yUzpj2Zj 5Ym61ZRmqQ3DPrfbITu3j1YnCKySperMNZP3cU9/bdO1TgPDWdDmjQ7d0qmWsdesIvOB bpIYUeLDljadMWctNzF83RAoClWIdr6ZSV9f6nz8BgpWTi2y0Wbqedj2QUGb4eXYyhXl YxdqabjHzf9qfpd/LXuXtREuBS0/PiNBbOp/snlxaqVb4l4MNvOyJybjndDRwjdnl8LP v+6owkZu7AR/Jbyz9Uap9KGe77zwO5b6d8Qz+tNE0W5rLJK5uCHXMlkkdJN/ItaZQ7br qxOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=dv9TSD+/zxgm/yZVTdNRQIspGlxRYBMrFGrvVlcEuDjuCJGfjbkcl4fB7m+K0+QpRc xRLFl6s1yyzA1Z1gC+3E/ew1oLXbLdhG7F6llbOc0idow1ssZYNqIDpCxmW6OSUS2ep3 9O6O5ahQD2mdrsEifB6xZYfcdHhbozCMY3jZly03/gnEy0nfiHFYUNKxAMfH+EJu8jnt cLaAhLXOcd4sgdcNg6on5ob8sFHns02n63ZdpLMR6i+GiYiT2M80QVfvg59xsSk66ICW tFV1Xch1nqI+c1YPzUQHZOlDaRspf7QkOqNLWV1H461dWRxONK/zt10gOl5pF2nH7HpT IgOw== X-Gm-Message-State: AOAM530ak0C9o3eNm8kr12FwJrjk+Iud38rj/I9skiFPJv0gGYwQmYIR m7/mRpfIqEYHbWPrkcOm3YSNmA== X-Google-Smtp-Source: ABdhPJzmXBAH1xHG/f+/U5CPsM7W8OR1I8fHDdWt1wtsnnCdoWIGjeRov6Uqg+/snJgO/SsCP9UkMg== X-Received: by 2002:a1c:7e90:: with SMTP id z138mr9010367wmc.7.1594994078207; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:37 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Date: Fri, 17 Jul 2020 14:54:21 +0100 Message-Id: <20200717135424.2442271-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095439_191251_A97DCB3C X-CRM114-Status: GOOD ( 12.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones --- drivers/spi/spi-topcliff-pch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af74743e..baadd380cb297 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl { /** * struct pch_spi_data - Holds the SPI channel specific details * @io_remap_addr: The remapped PCI base address + * @io_base_addr: Base address * @master: Pointer to the SPI master structure * @work: Reference to work queue handler * @wait: Wait queue for waking up upon receiving an @@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl { * transfer * @rx_index: Receive data count; for bookkeeping during * transfer - * @tx_buff: Buffer for data to be transmitted - * @rx_index: Buffer for Received data + * @pkt_tx_buff: Buffer for data to be transmitted + * @pkt_rx_buff: Buffer for received data * @n_curnt_chip: The chip number that this SPI driver currently * operates on * @current_chip: Reference to the current chip that this SPI @@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl { * @board_dat: Reference to the SPI device data structure * @plat_dev: platform_device structure * @ch: SPI channel number + * @dma: Local DMA information + * @use_dma: True if DMA is to be used * @irq_reg_sts: Status of IRQ registration + * @save_total_len: Save length while data is being transferred */ struct pch_spi_data { void __iomem *io_remap_addr;