From patchwork Fri Jul 17 13:54:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670433 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0022660D for ; Fri, 17 Jul 2020 13:57:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC9AB20717 for ; Fri, 17 Jul 2020 13:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L0RS17uJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BJWYGXYq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC9AB20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rK9jXS8VMe5whwJShosUusivPUtIdeDEn/NwAl2che8=; b=L0RS17uJK+ASlzyqfVAyDibGK NuFw/u0+dlGYsmEV5iEr7FKOYkFGAbRubQ5xPNDdHj+g6ZT8ZXE9vYO0CMzYx/edua/JaVfLr/C0V 4F+Sf9AhQmUtvJvCjVGepDQ54nSUR4xb73MRQTQga3uBNrlbB0pzmEWOJC/gcF878k0oLspypMEI0 AzhaObLHFslzf12X47MHJbYQC3UOeQKI7npONjTmn/nbq/VetCA5tE5ohAHfWI7GvvHAdzGGjuZH6 zEsKGqTq2wMWrufBo2+nnQ+d2hmL7SBAWd2MA5i80g4qPHkV63zanLSlwwK/dZRBb8eivbDCN2lIL kKAkUkwDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqW-0003dA-6k; Fri, 17 Jul 2020 13:56:17 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQoz-0002vP-P5 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:42 +0000 Received: by mail-wr1-x442.google.com with SMTP id j4so11180695wrp.10 for ; Fri, 17 Jul 2020 06:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=BJWYGXYq1pgsO4ivqCiR82eR35O7gSNMT6QzlxPG0J5WFo7f9l9ct2/Tj5hbius4wJ Z3Nj9oYaqBKMg1Xoi6M4UZkmmfrLIkOblh0TJcSGnmWoWrAo6+546QwFRUIZFYt0uk9F P4n6sI1WeB+yEJLGruWOY5oFh5vAAwBE0sSKpokIUpMVYM0U5mlq0hoKOTFrP6pj1ogt qBVxuMuEOaLVOwxwyszj1rDIl05cV1teNU20ANvSq5UID796wEmfuWiVh9kq+r3ORgD1 CKk+4gQ6lc1SCsduPRjx9fMiZ8f6nvrTSL7uHPXLrhtjK2mTSQcMBXQMTJfGqOP5i/M3 qjLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=tOAXubG/DpEWqXE539ByICMlJHksEahI7ThSrU6Yzrp6X2odVXeafqV/YTGmoWMBxD aJzapKbKCim9mOq5rVvRX1iOy4geHET8qKxX9hzGW9m5LSnes2PKhguJ7rqWFezKfyw9 FI24538X6QM4sWOUTkdQ7zbhOGQVSQDozakzPOGaBSNXWtzUDU5EgdvASGqVKEzO5nPO XwZA/m9olk2yDwjCzj18irN/ctAYVF75fv9rTY1naOxCm4Ls2VswxF6+dOur7UG0h5lK B3VHozIv+wmOGd0JFZoKYdjdUhVp+vA6sbM6YxBtBmRFnqombbuS/7RTEEUkhbEzBt2D CNvQ== X-Gm-Message-State: AOAM533vBTvAEQdKtfNaqn9ck/XbT0lsFw0WHxegCSd0TjZ8YUpVU88Q ZWsP5MWk1zjQ9c44hv2uVCrgcw== X-Google-Smtp-Source: ABdhPJzcxiqCEsLDkUJ5mleRr1Wv9TnyI904k47F56Gh6ETTAgfzBGp386wph9T+fLWOu0SbjVA3ng== X-Received: by 2002:adf:f104:: with SMTP id r4mr10951860wro.90.1594994080427; Fri, 17 Jul 2020 06:54:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:39 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 17 Jul 2020 14:54:23 +0100 Message-Id: <20200717135424.2442271-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095441_858258_0FDEBB19 X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Robert Jarzmik , linux-kernel@vger.kernel.org, Haojian Zhuang , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'pxa2xx_spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pxa2xx.c:1435:36: warning: ‘pxa2xx_spi_acpi_match’ defined but not used [-Wunused-const-variable=] 1435 | static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Lee Jones --- drivers/spi/spi-pxa2xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 0040362b71622..814268405ab0b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1432,6 +1432,7 @@ static void cleanup(struct spi_device *spi) kfree(chip); } +#ifdef CONFIG_ACPI static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { "INT33C0", LPSS_LPT_SSP }, { "INT33C1", LPSS_LPT_SSP }, @@ -1442,6 +1443,7 @@ static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { }, }; MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); +#endif /* * PCI IDs of compound devices that integrate both host controller and private