| Message ID | 20200717165538.3275050-31-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Second batch of W=1 fixes for IIO | expand |
Am Freitag, 17. Juli 2020, 18:55:38 CEST schrieb Lee Jones: > This is the only use of kerneldoc in the source file and no > descriptions are provided. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' > > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: linux-rockchip@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Subject-line says "Demote Demote..." Otherwise Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/iio/adc/rockchip_saradc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index 582ba047c4a67..cf4ec59c1dab0 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { > }; > MODULE_DEVICE_TABLE(of, rockchip_saradc_match); > > -/** > +/* > * Reset SARADC Controller. > */ > static void rockchip_saradc_reset_controller(struct reset_control *reset) >
On Fri, 17 Jul 2020 21:10:27 +0200 Heiko Stübner <heiko@sntech.de> wrote: > Am Freitag, 17. Juli 2020, 18:55:38 CEST schrieb Lee Jones: > > This is the only use of kerneldoc in the source file and no > > descriptions are provided. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' > > > > Cc: Heiko Stuebner <heiko@sntech.de> > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: linux-rockchip@lists.infradead.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Subject-line says "Demote Demote..." > > Otherwise > Reviewed-by: Heiko Stuebner <heiko@sntech.de> Fixed up and applied. Thanks for whole set Lee. Jonathan > > > > --- > > drivers/iio/adc/rockchip_saradc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > > index 582ba047c4a67..cf4ec59c1dab0 100644 > > --- a/drivers/iio/adc/rockchip_saradc.c > > +++ b/drivers/iio/adc/rockchip_saradc.c > > @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { > > }; > > MODULE_DEVICE_TABLE(of, rockchip_saradc_match); > > > > -/** > > +/* > > * Reset SARADC Controller. > > */ > > static void rockchip_saradc_reset_controller(struct reset_control *reset) > > > > > >
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c index 582ba047c4a67..cf4ec59c1dab0 100644 --- a/drivers/iio/adc/rockchip_saradc.c +++ b/drivers/iio/adc/rockchip_saradc.c @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = { }; MODULE_DEVICE_TABLE(of, rockchip_saradc_match); -/** +/* * Reset SARADC Controller. */ static void rockchip_saradc_reset_controller(struct reset_control *reset)
This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller' Cc: Heiko Stuebner <heiko@sntech.de> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/iio/adc/rockchip_saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)