| Message ID | 20200718054040.3996-1-christianshewitt@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f1bb924e8f5b50752a80fa5b48c43003680a7b64 |
| Headers | show |
| Series | arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3 | expand |
Christian Hewitt <christianshewitt@gmail.com> writes: > Similar to other G12B devices using the W400 dtsi, I see reports of mmc0 > tuning errors on VIM3 after a few hours uptime: > > [12483.917391] mmc0: tuning execution failed: -5 > [30535.551221] mmc0: tuning execution failed: -5 > [35359.953671] mmc0: tuning execution failed: -5 > [35561.875332] mmc0: tuning execution failed: -5 > [61733.348709] mmc0: tuning execution failed: -5 > > I do not see the same on VIM3L, so remove sd-uhs-sdr50 from the common dtsi > to silence the error, then (re)add it to the VIM3L dts. > > Signed-off-by: Chrisitan Hewitt <christianshewitt@gmail.com> Fixes? Kevin
> On 21 Jul 2020, at 2:24 am, Kevin Hilman <khilman@baylibre.com> wrote: > > Christian Hewitt <christianshewitt@gmail.com> writes: > >> Similar to other G12B devices using the W400 dtsi, I see reports of mmc0 >> tuning errors on VIM3 after a few hours uptime: >> >> [12483.917391] mmc0: tuning execution failed: -5 >> [30535.551221] mmc0: tuning execution failed: -5 >> [35359.953671] mmc0: tuning execution failed: -5 >> [35561.875332] mmc0: tuning execution failed: -5 >> [61733.348709] mmc0: tuning execution failed: -5 >> >> I do not see the same on VIM3L, so remove sd-uhs-sdr50 from the common dtsi >> to silence the error, then (re)add it to the VIM3L dts. >> >> Signed-off-by: Chrisitan Hewitt <christianshewitt@gmail.com> > > Fixes? > > Kevin I’ll resend v2 with the fixes tag(s). Thanks. Christian
diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi index 27408c10a811..ddfd52b88002 100644 --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi @@ -293,7 +293,6 @@ bus-width = <4>; cap-sd-highspeed; - sd-uhs-sdr50; max-frequency = <100000000>; non-removable; diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts index dbbf29a0dbf6..026b21708b07 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts @@ -88,6 +88,10 @@ status = "okay"; }; +&sd_emmc_a { + sd-uhs-sdr50; +}; + &usb { phys = <&usb2_phy0>, <&usb2_phy1>; phy-names = "usb2-phy0", "usb2-phy1";
Similar to other G12B devices using the W400 dtsi, I see reports of mmc0 tuning errors on VIM3 after a few hours uptime: [12483.917391] mmc0: tuning execution failed: -5 [30535.551221] mmc0: tuning execution failed: -5 [35359.953671] mmc0: tuning execution failed: -5 [35561.875332] mmc0: tuning execution failed: -5 [61733.348709] mmc0: tuning execution failed: -5 I do not see the same on VIM3L, so remove sd-uhs-sdr50 from the common dtsi to silence the error, then (re)add it to the VIM3L dts. Signed-off-by: Chrisitan Hewitt <christianshewitt@gmail.com> --- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 1 - arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-)