Message ID | 20200721094445.82184-2-dbrazdil@google.com (mailing list archive) |
---|---|
State | Mainlined |
Commit | 24f69c0fa4e252f706884114b7d6353aa07678b5 |
Headers | show
Return-Path: <SRS0=yukz=BA=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6ED66C1 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 21 Jul 2020 09:46:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0AA3206E9 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 21 Jul 2020 09:46:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FQMj09yC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="i7S9t2tE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0AA3206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LWMyeVtHmow0afwuO1iRl5YS2OAZDLb4MToSwZoTXmM=; b=FQMj09yCj04Pcy5fKk99cG2Q6 t7dWGfAqqW1YkpKpOAT29Y0EFu+CzBt/2yvaV5Z3idV18CoXImQQld0FRx9ceBcjD+gjhEnbHKTq6 2F7A2sjMJabIcLsGM/WMZ51oP7tlfcVd58bNkBjIgk3mfsNskWx6C6J5L3tTmErzNYK15bQSSYRSW cqCv76QZy7s7YMbWvRHOSlwWjBWyhgj5oGjQkFL+YRdb+xjNWN+s6Ot9dw8bOFjkuv2JBpxa06NMG fL8eLSwTLu66oDiuDSQj7TGzEipqEoNIjvnuuPrCkXptSnAccpccJeoiRYXw+j/16qf5v8vtSvLkC 6GDGSwq4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxoph-0002I8-1m; Tue, 21 Jul 2020 09:45:09 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxopY-0002F6-Rn for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 09:45:02 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so20473030wrw.12 for <linux-arm-kernel@lists.infradead.org>; Tue, 21 Jul 2020 02:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VCTmXoCDoueHGgkSs0dR8Q0gxBgF8BRtzs8whbeoPBY=; b=i7S9t2tE6o1ZpRYbBoPLh0mSIFrwHpF9lRxApXBd0SVtfEaMYvKF999IuDfaCE0DdV wFP+lVdRe3oBxP2XXvkxkBId3a9rt+6LPKWVsl+ePCY53KV/eftUkC17hvcyirlr+CGK x7ecwNpbckzsh0wui6eblLsfMr8GEq9ZrWF10CjkBxj2vMY7btc6zTVBhf2gFaf+aYKQ Z9o0w00u6PzL/RWmFmEzV0p9EKWUu+yEx7/TbdTY8Td8Japa4BSiSwPQ6XbmtKjsTrTi vXBWkcRXULUnuwkT7FCat/ZEFHAvwe0oSFvoHGLxUv4FYZhSJU1tk0eMqjkihc349oCz jYCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VCTmXoCDoueHGgkSs0dR8Q0gxBgF8BRtzs8whbeoPBY=; b=JPKSjZfQPnwq9bc/kvmA8JhiF3UhO+i82p3LmbTFwP3XMxq/2BTN/aUWFwVcJlgc8K JOPjI+PZ2jCtDEL6ZvHpMN4Vkqp57v+DjKeiV9Rc5lOlUgeNOdJMppBwfkIhB4a7bqul Q5TmnAPbIplMthPh5eXsrj796Uf6WwVjbPjEEOhiauoAWFHlqc0KqUTpyHD9uMHWjUZm IUGfLRC1VlZ3w4e1Q4NrXuzcO9zzceRsVqjnY9V264S+yGvTbcw9NrrtIYSf5HSfkcc9 xvTioLB+wIGNzutTIVoY6Rs+U6J+zlxA1BwBwL/dP1wq2yjrUaydl5FS4y4nDhG4xfOx PvHQ== X-Gm-Message-State: AOAM532uwTL7+Qmj5yCUlZFGbtTJbLXCpIoKsp2ObVYMMNWUM4jn9WjH 7ONlUconyyUdzH8DJDudN/VloA== X-Google-Smtp-Source: ABdhPJwsEeqkTbsLPEJadyPaueujiKzL/IxGYymb0jshDg7vVUsqj2qjWEo9k1RSpX4pHM494OqVlA== X-Received: by 2002:adf:f542:: with SMTP id j2mr25975490wrp.61.1595324699596; Tue, 21 Jul 2020 02:44:59 -0700 (PDT) Received: from localhost ([2a01:4b00:8523:2d03:cd93:4ca4:af31:19e5]) by smtp.gmail.com with ESMTPSA id l1sm39195773wrb.12.2020.07.21.02.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2020 02:44:58 -0700 (PDT) From: David Brazdil <dbrazdil@google.com> To: Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, James Morse <james.morse@arm.com>, Julien Thierry <julien.thierry.kdev@gmail.com>, Suzuki K Poulose <suzuki.poulose@arm.com> Subject: [PATCH 1/2] KVM: arm64: Make nVHE ASLR conditional on RANDOMIZE_BASE Date: Tue, 21 Jul 2020 10:44:44 +0100 Message-Id: <20200721094445.82184-2-dbrazdil@google.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200721094445.82184-1-dbrazdil@google.com> References: <20200721094445.82184-1-dbrazdil@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_054500_969191_5DBEDA4E X-CRM114-Status: GOOD ( 13.81 ) X-Spam-Score: -15.7 (---------------) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-15.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -7.5 USER_IN_DEF_DKIM_WL From: address is in the default DKIM white-list -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF white-list 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL Match -0.0 DKIMWL_WL_MED DKIMwl.org - Medium sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: android-kvm@google.com, linux-kernel@vger.kernel.org, David Brazdil <dbrazdil@google.com>, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Unify non-VHE ASLR features behind CONFIG_RANDOMIZE_BASE
|
expand
|
diff --git a/arch/arm64/kvm/va_layout.c b/arch/arm64/kvm/va_layout.c index a4f48c1ac28c..e0404bcab019 100644 --- a/arch/arm64/kvm/va_layout.c +++ b/arch/arm64/kvm/va_layout.c @@ -48,7 +48,7 @@ __init void kvm_compute_layout(void) va_mask = GENMASK_ULL(tag_lsb - 1, 0); tag_val = hyp_va_msb; - if (tag_lsb != (vabits_actual - 1)) { + if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && tag_lsb != (vabits_actual - 1)) { /* We have some free bits to insert a random tag. */ tag_val |= get_random_long() & GENMASK_ULL(vabits_actual - 2, tag_lsb); }
If there are spare bits in non-VHE hyp VA, KVM unconditionally replaces them with a random tag chosen at init. Disable this if the kernel is built without RANDOMIZE_BASE to align with kernel behavior. Signed-off-by: David Brazdil <dbrazdil@google.com> --- arch/arm64/kvm/va_layout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)