From patchwork Fri Aug 7 13:19:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Brugger X-Patchwork-Id: 11705707 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 41E2A618 for ; Fri, 7 Aug 2020 13:19:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C3C42086A for ; Fri, 7 Aug 2020 13:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qmBjs6os"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="K3+w16/v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C3C42086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=MSSloWAIvLa0fLuEK0uq7umcLqHHf8Uk0/XU+VinEeU=; b=qmBjs6oseXpFECej35tDxHvuhv L5o4xjmKMaWtpppl7rj8CHx+f9WkkNRQCjH+GRyO3RBfJ9OyM9Pr/jcixFAfpzhVIsP6Eca/syYlk 5EPlogOgUrvsaVj05Wy+FVd1u46DBVYDHaTs1iUwEXxFhjNe7itkOrOd+vhqvw0MAYT0nUWfwS2po zL81a3BxUr3ZIpfbF+oprYeYwtp3B/qYT7x/3rcep19nZ3+9liLt0hV5SvUV2iGcs92Dp4uCQ2Jxp P+FDdfim+8mXjuA0+duB9fe90lgZKXqTE2ZFS2/nWJwmWWngL3EIgkT2S225mVHdar7uTrhoMDevl dXI0HO2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k42HG-00084j-GY; Fri, 07 Aug 2020 13:19:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k42HE-00083z-1X; Fri, 07 Aug 2020 13:19:16 +0000 Received: from ziggy.com (81.172.57.81.dyn.user.ono.com [81.172.57.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E29522086A; Fri, 7 Aug 2020 13:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596806354; bh=90W/RlmEX3PAdf4oEsZD+boIBLyjUS1TrXoIlmoXv6M=; h=From:To:Cc:Subject:Date:From; b=K3+w16/vPkbiOROuEmRUBKt2EyFZDHkhwM5D5RPR/xWJI8gBlWeT59Be2kccdeeRA sQapHJNEC+JUFGTMpNd6O9xDexL3aIIAvw7Ip+Un4iDC7tbW0jmLN+maSqoWj7tUOr RRdZl8udmoxeaVGeBQbK1KrJszBNor5PMilIcjUU= From: matthias.bgg@kernel.org To: qii.wang@mediatek.com, matthias.bgg@gmail.com, wsa@the-dreams.de, yingjoe.chen@mediatek.com Subject: [v2] i2c: mediatek: Fix i2c_spec_values description Date: Fri, 7 Aug 2020 15:19:04 +0200 Message-Id: <20200807131904.6515-1-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_091916_185034_E7E63F02 X-CRM114-Status: GOOD ( 11.45 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthias Brugger , linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Matthias Brugger The struct i2c_spec_values have it's members documented but is missing the starting '@', which leads to warings like: drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_low_ns' not described in 'i2c_spec_values' We also delete min_high_ns member as it is not used in the code. Signed-off-by: Matthias Brugger Reviewed-by: Qii Wang --- Changes since v1: delete mint_high_ns member drivers/i2c/busses/i2c-mt65xx.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index e889f74703e4..efc14041d45b 100644 --- a/drivers/i2c/busses/i2c-mt65xx.c +++ b/drivers/i2c/busses/i2c-mt65xx.c @@ -253,14 +253,13 @@ struct mtk_i2c { /** * struct i2c_spec_values: - * min_low_ns: min LOW period of the SCL clock - * min_su_sta_ns: min set-up time for a repeated START condition - * max_hd_dat_ns: max data hold time - * min_su_dat_ns: min data set-up time + * @min_low_ns: min LOW period of the SCL clock + * @min_su_sta_ns: min set-up time for a repeated START condition + * @max_hd_dat_ns: max data hold time + * @min_su_dat_ns: min data set-up time */ struct i2c_spec_values { unsigned int min_low_ns; - unsigned int min_high_ns; unsigned int min_su_sta_ns; unsigned int max_hd_dat_ns; unsigned int min_su_dat_ns;