From patchwork Sun Aug 23 02:25:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Healy X-Patchwork-Id: 11731359 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B519F109B for ; Sun, 23 Aug 2020 02:25:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81E5E20724 for ; Sun, 23 Aug 2020 02:25:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sF4O9dUJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dgYnjdt7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81E5E20724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=7+ZXxnwQdiX21xE1jjKXCCQuoeAVX94hB2GFKFy2g9U=; b=sF4O9dUJ0wEmg7SWF95S45WYuY BlJCVM3Q7CsnWI7edfcVJ3pQUDXrjvL3dr5kf6kd+mK3zbckwkMMm+Zi+6Z02xKj+DnTTF1cQAw1M wN/3tPZoc3mz80/15bEz0fMF57fTiLbN1fU6khzZZ47nNzfHBZoqJp0nlgMGTNKa18mnyhfi4sS7Y xWZzCx5GKpaaXoZIjWBZCIhJt7DH9EmA5GGz4ySwtBwEfoM5d/TNN0PhoL5hqT85mgNq/Ngfrm9sJ 1uck5zwBDJaeGp+looN3MtpZo+6VarVkhWeCMmqX7vLMb+7+3V1xkhwNSU5L8qV1zoIJXPmb7puNG q9H55jdA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9fhY-0005U9-BO; Sun, 23 Aug 2020 02:25:44 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9fhV-0005TO-J0 for linux-arm-kernel@lists.infradead.org; Sun, 23 Aug 2020 02:25:42 +0000 Received: by mail-pl1-x642.google.com with SMTP id q3so1279862pls.11 for ; Sat, 22 Aug 2020 19:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HjidLqGbJG8Me/D9pV5CMHOfGHdBLM7VaSZt6TwM0nE=; b=dgYnjdt7h1nUl7wOnJltPzk+Dxnmy5hZxJcDdq6KydTszr1V744le1tP/k4zmkv5vP z9OuSt/5za8/BFs1vOnN45xhJJ83SkFvFUyMYMLs5HRq0f0GGkn+Jf8QJw3/xcVO1juZ 7TNhl41/LuPQPz1O+TPVDOZvpOju6x6dk5hPLgSz4wTIaZnXU6BCispY4OgHRJFBOhF5 ZXTUN6kEmJo7WoBim8voAy1ZskQQJYoyNkuFYO7ldLF8HtJ1vrKM1J6aZTbP2ihA2BSr jfy5VRJSUh59tMB7dCbpg09/Vz8VpphV8f+yrUktpncOpCHpLL3XPxYa1ZERdJhqGj3I cJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HjidLqGbJG8Me/D9pV5CMHOfGHdBLM7VaSZt6TwM0nE=; b=r7KyGWPCNCphz1clRA6OJuFC8oyvRv08ChuKgO/S/j/bfGVWZzZeWiPZ9ocRz7TYGK SVw66CtCLYBkCOnEouk/vr+Y4aaUD6o3ZilaRZeh6p53To4UhBlRsS4tvFI1+3xy2aFc 4JIVSeestTFdlMSfzRRo92QFAohQ9Ey3yyO+5EaV6iNmj5WeU1H9G6JDsQOMA+o5RaLJ wKmTdcqmAdxeM5be5l0RCOnBGy5LM3OYwvWyDmXlNz2k1Fn15gqWO8E9pWlXT2dn2dpW Ru6vk3vVjFfMB+utHaOrguqs7CsvsXQWajZfSWh85+JI0arirVqFhvNgGiKAA4tMpBoJ fz8w== X-Gm-Message-State: AOAM530RnKW0/KNpYCMpVOiBg3fYTw2kM027rXaIM57lc/pnicZ31k3V 3p9WGceIykiBzUyZRcbjlcw= X-Google-Smtp-Source: ABdhPJxfJxPaPZgx5Zokq/Cplk371Fn6Oi9EjWoRwwJVJwvZyj9XKCjxZFA/4EUkVrZ5rm5mM2F8fw== X-Received: by 2002:a17:902:b098:: with SMTP id p24mr45366plr.255.1598149539171; Sat, 22 Aug 2020 19:25:39 -0700 (PDT) Received: from localhost.localdomain.com ([2605:e000:160b:911f:722f:a74:437d:fd3c]) by smtp.gmail.com with ESMTPSA id k8sm6177710pgt.54.2020.08.22.19.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2020 19:25:38 -0700 (PDT) From: Chris Healy X-Google-Original-From: Chris Healy X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_222541_698009_41AEEB2F X-CRM114-Status: GOOD ( 15.56 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [cphealy[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Healy Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Chris Healy Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board. The end result is that network receive behaviour is marginal with lots of RX CRC errors experienced and NFS frequently failing. Quoting the explanation from Andrew Lunn in commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X phy-mode"): "The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue" Fix it by switching to phy-mode = "rgmii-id". Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") Signed-off-by: Chris Healy Reviewed-by: Fabio Estevam --- arch/arm/boot/dts/imx7d-zii-rmu2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7d-zii-rmu2.dts b/arch/arm/boot/dts/imx7d-zii-rmu2.dts index e5e20b07f184..7cb6153fc650 100644 --- a/arch/arm/boot/dts/imx7d-zii-rmu2.dts +++ b/arch/arm/boot/dts/imx7d-zii-rmu2.dts @@ -58,7 +58,7 @@ &fec1 { <&clks IMX7D_ENET1_TIME_ROOT_CLK>; assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; assigned-clock-rates = <0>, <100000000>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <&fec1_phy>; status = "okay";