From patchwork Wed Aug 26 14:49:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 11738839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C459613B1 for ; Wed, 26 Aug 2020 15:03:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F3D92078A for ; Wed, 26 Aug 2020 15:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MDtLpLyI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ea2xvkOc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F3D92078A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ejZPMEvUD1Fn8Ps8ycl8/uTpPjTuzqj9wVo7qgJNThg=; b=MDtLpLyIPj2CTNsq0NzmHHWqwr N657obQUg8qm7sIfr322MwHbvjckWNoGuS/Nj+pLQg9ik1sGXMds8Z9IYquMrDBSQTNBJTpsbuNv0 MVI0xwBb9I4nlDtB84hw37/jf8BUNNTYmmX8kEOLWqOkewqTetpaqJdLDHFubwhaGBmEBl79I5U0b vj4iR21OZX6U1kUEwCz0irNZ9Me7hz3cceYlB65WWQ3PWKD5zq30QXq9+J0C1ZM5J4udWuPTCpAAr oaPceFwnZnJ5JFb/fcYqRPnPPu+GK6rkRm+MfM44Xdi8pavuZgemausYGVPSX8FVhQOGCV1TyZDdF /uiYbTxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAwud-0006PV-Aa; Wed, 26 Aug 2020 15:00:31 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAwpH-000345-Qe for linux-arm-kernel@merlin.infradead.org; Wed, 26 Aug 2020 14:54:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=UNgoaYovrgyCDjH3s+7eTkkuCiHO3RtpBAMTIsFMWD8=; b=Ea2xvkOcI4O/Dca5chPyfHNpZs /TH0HibFCvD8O45Ys9HHF43f65rJkAI6u1mEhWzl/fCzSVux9os7M5invNbVo3ZLTVjo85l8xcgwa MdMBDp8X+EdlFFiE3ymOa0YTG/WyXA9SIQpjnYNOu4Ajp0mqAXHsrkCnBr4QF1jq2mQIgpAsTMB5y dWmD3yKaYIJ1/5SuYVWuwqejBKpTZtKBcopbdiKlcniumanaIr833wXy3FcMvNfqH6zZQPgm6Cs4M 6lo/0aYcUQ1kfbNsizTfrwJ8QJEGdXwLLwt1fp3pDCxdBixFeBfBNjVeUOeYTfRB1ze6w1QM4gWJY 9DlJC3ig==; Received: from cmccmta1.chinamobile.com ([221.176.66.79]) by casper.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAwp7-000200-7N for linux-arm-kernel@lists.infradead.org; Wed, 26 Aug 2020 14:54:58 +0000 Received: from spf.mail.chinamobile.com (unknown[172.16.121.11]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15f46765ae56-58880; Wed, 26 Aug 2020 22:48:59 +0800 (CST) X-RM-TRANSID: 2ee15f46765ae56-58880 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.0.144.112]) by rmsmtp-syy-appsvr06-12006 (RichMail) with SMTP id 2ee65f467658e6c-12e8e; Wed, 26 Aug 2020 22:48:59 +0800 (CST) X-RM-TRANSID: 2ee65f467658e6c-12e8e From: Tang Bin To: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, kgene@kernel.org, krzk@kernel.org Subject: [PATCH] usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe() Date: Wed, 26 Aug 2020 22:49:31 +0800 Message-Id: <20200826144931.1828-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_155450_159625_6A7791FD X-CRM114-Status: GOOD ( 10.81 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [221.176.66.79 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Tang Bin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Shengju , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ohci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 62194244cf87 ("USB: Add Samsung Exynos OHCI diver") Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Krzysztof Kozlowski --- drivers/usb/host/ohci-exynos.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index bd40e597f..5f5e8a64c 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -171,9 +171,8 @@ static int exynos_ohci_probe(struct platform_device *pdev) hcd->rsrc_len = resource_size(res); irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(&pdev->dev, "Failed to get IRQ\n"); - err = -ENODEV; + if (irq < 0) { + err = irq; goto fail_io; }