| Message ID | 20200913122644.35515-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rtc: st-lpc: Constify st_rtc_ops | expand |
On Sun, 13 Sep 2020 14:26:44 +0200, Rikard Falkeborn wrote: > The only usage of st_rtc_ops is to assign its address to the ops field > in the rtc_device struct. which is a const pointer. Make it const to > allow the compiler to put it in read-only memory. Applied, thanks! [1/1] rtc: st-lpc: Constify st_rtc_ops commit: d0a3b65052f041852c855ea1135659770ba0bc09 Best regards,
diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c index 51041dc08af4..0c65448b85ee 100644 --- a/drivers/rtc/rtc-st-lpc.c +++ b/drivers/rtc/rtc-st-lpc.c @@ -173,7 +173,7 @@ static int st_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *t) return 0; } -static struct rtc_class_ops st_rtc_ops = { +static const struct rtc_class_ops st_rtc_ops = { .read_time = st_rtc_read_time, .set_time = st_rtc_set_time, .read_alarm = st_rtc_read_alarm,
The only usage of st_rtc_ops is to assign its address to the ops field in the rtc_device struct. which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/rtc/rtc-st-lpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)