From patchwork Fri Sep 18 08:04:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wangshaobo (bobo)" X-Patchwork-Id: 11784223 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F78F14B7 for ; Fri, 18 Sep 2020 08:05:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62F5F20717 for ; Fri, 18 Sep 2020 08:05:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KShAIKtB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F5F20717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=rNZjuKa9VgkOV5mVpV3AOZ7x5HoiMsPPmUo7HaUWt8k=; b=KShAIKtBVM/0rUNU3EXt9KVg5Y 6qnZYjVYJbByxLQoyOydx8InZweirYuwtg/XYLra/kzSva7v7dholcv3NuAYFzIKHjcMCp4TDQkuz nXgLa1tKw8cOW63i6NNvWroEpxzT3tSVKGUVwOQkVZeyXgjCo4rRH3My9j7sLmb+JSxZ6qZ5/TzU4 ngjl07e7BypnCzRni6wNcE3cmxFH+xXebh9rhK1adrQzpCZ8kQhzN7lC/3knpm0mZRc8g28J3DhFr ErqNOWpaKAiye9WG/CMabcfwl4TE4YZ1zbb4zR9l/RKo1rfts1LW87YzMNLV1RGfVPTQm4dZG2SYo fy0oH1mg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJBOt-0008HA-D3; Fri, 18 Sep 2020 08:05:47 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJBOo-0008DV-Up for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 08:05:46 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0E486653FFD84CAC8FEA; Fri, 18 Sep 2020 16:05:34 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Fri, 18 Sep 2020 16:05:24 +0800 From: Wang ShaoBo To: Subject: [PATCH -next] ARM: zx: Use devm_platform_ioremap_resource() Date: Fri, 18 Sep 2020 16:04:50 +0800 Message-ID: <20200918080451.31938-1-bobo.shaobowang@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_040545_263175_42DA6EE7 X-CRM114-Status: GOOD ( 10.89 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [45.249.212.190 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [45.249.212.190 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cj.chengjian@huawei.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, huawei.libin@huawei.com, olof@lixom.net, jun.nie@linaro.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Make use of devm_platform_ioremap_resource() provided by driver core platform instead of duplicated analogue. dev_err() is removed because it has been done in devm_ioremap_resource(). Signed-off-by: Wang ShaoBo --- arch/arm/mach-zx/zx296702-pm-domain.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index 7a08bf9dd792..8ddc94530d5d 100644 --- a/arch/arm/mach-zx/zx296702-pm-domain.c +++ b/arch/arm/mach-zx/zx296702-pm-domain.c @@ -152,7 +152,6 @@ static struct generic_pm_domain *zx296702_pm_domains[] = { static int zx296702_pd_probe(struct platform_device *pdev) { struct genpd_onecell_data *genpd_data; - struct resource *res; int i; genpd_data = devm_kzalloc(&pdev->dev, sizeof(*genpd_data), GFP_KERNEL); @@ -162,17 +161,9 @@ static int zx296702_pd_probe(struct platform_device *pdev) genpd_data->domains = zx296702_pm_domains; genpd_data->num_domains = ARRAY_SIZE(zx296702_pm_domains); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENODEV; - } - - pcubase = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pcubase)) { - dev_err(&pdev->dev, "ioremap fail.\n"); + pcubase = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(pcubase)) return -EIO; - } for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i) pm_genpd_init(zx296702_pm_domains[i], NULL, false);