| Message ID | 20200929032005.15169-3-crystal.guo@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | watchdog: mt8192: add wdt support | expand |
On 29/09/2020 05:20, Crystal Guo wrote: > update mtk-wdt document for MT8192 platform > > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Guenter Roeck <linux@roeck-us.net> You added Guenters Reviewed-by in v4 of this series, but I don't see that on Guenter provided this tag. In the future please make sure that you don't add tags to your patches that were not provided. This creates great confusion. Regards, Matthias > --- > Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > index 45eedc2c3141..e36ba60de829 100644 > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > @@ -12,6 +12,7 @@ Required properties: > "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 > "mediatek,mt8183-wdt": for MT8183 > "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 > + "mediatek,mt8192-wdt": for MT8192 > > - reg : Specifies base physical address and size of the registers. > >
On Fri, 2020-10-02 at 17:28 +0800, Matthias Brugger wrote: > > On 29/09/2020 05:20, Crystal Guo wrote: > > update mtk-wdt document for MT8192 platform > > > > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com> > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > You added Guenters Reviewed-by in v4 of this series, but I don't see that on > Guenter provided this tag. In the future please make sure that you don't add > tags to your patches that were not provided. This creates great confusion. > > Regards, > Matthias > Hi Guenter, Should I remove the "Reviewed-by:Guenter" tag, and re-submit this patch for your review, or keeping the status quo and wait for Wim's comment? Thanks Crystal > > --- > > Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > > index 45eedc2c3141..e36ba60de829 100644 > > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > > @@ -12,6 +12,7 @@ Required properties: > > "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 > > "mediatek,mt8183-wdt": for MT8183 > > "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 > > + "mediatek,mt8192-wdt": for MT8192 > > > > - reg : Specifies base physical address and size of the registers. > > > >
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt index 45eedc2c3141..e36ba60de829 100644 --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt @@ -12,6 +12,7 @@ Required properties: "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 "mediatek,mt8183-wdt": for MT8183 "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 + "mediatek,mt8192-wdt": for MT8192 - reg : Specifies base physical address and size of the registers.