From patchwork Mon Oct 5 17:37:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moritz Fischer X-Patchwork-Id: 11817139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1ED86112E for ; Mon, 5 Oct 2020 17:38:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7C982080A for ; Mon, 5 Oct 2020 17:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sSNTBRkq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7C982080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WaUN0Ltw+L7ghachus4BDkdhF01eN4puTQ+BqmfB+bw=; b=sSNTBRkqzgyUR6lVqcaQEpNyf 8DZ/it2G7SW7GKKeg2kZ/Qe79WOi9/8MmTTq0CoZCrhaDe9GKV5amfUBCCsI3jciRfWCw1ysiC8Lw ISlUvrq+idkrWkhUqsyfok19W9GDl84sjxathISx1m9mZEGzQCX+YP9kz1dXc27zHR9zUpZBlBuGC 7djNv0JrU9uC1lUFgkh9HG22GD73Leb9Y9sgcCdI6qFy38FX54M4+fEut3LsC/Gvqc35wyW7sj6lD rS3PrB/uhbTgFX9dpvk1N+yGtHqICXjqV7JikbAsV5/Ia2m+Vg8vSdI3rYApyImvZUHSGLvV4zLH8 e8THacWCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPURS-0007z2-B4; Mon, 05 Oct 2020 17:38:30 +0000 Received: from mail-pf1-f171.google.com ([209.85.210.171]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUQs-0007k0-81 for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 17:37:55 +0000 Received: by mail-pf1-f171.google.com with SMTP id w21so7398261pfc.7 for ; Mon, 05 Oct 2020 10:37:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S5exJHrExp6hH+fiLalmCGHAHxK2W/BK4vVbjWgODn4=; b=Jy7Hf3ngqLDz6mTdryVlEAMlE605ZGsGT6CzTSPQqaB5sKHqzmN4+lyKHT/jRuEo1y 1oC7rYd2yNiw3dHSO8OH8arrJklCvW56yqHt3wmFMMiGdpjaaVpgBit/PBp7+tVOBNgp RwExOmoHDFijf2cOE0T/1O921+fIhG/VJ/SmbVkLaVybK3XKmwwpMwNdmvKYWamnlfvt u52XTSNKwYlYn58oPtqw7QOTh9gUMK4ey2HOuHJq1HJswXxsG0b3KAU/CttffymT911J KbUPPVYWCTY88+ZKhiwOAQC0P6cDvnKTJx8ZaB/KS40iP80ZYDNesbJ+h4u7s8ZmhjXL 8gsw== X-Gm-Message-State: AOAM532areFMIQJLj6KSFW0C9hvBGx6CRLbJes7T7ClFrC4gi/8s1GBo t3tzyuCNEhKkaTTPXuALtrQ= X-Google-Smtp-Source: ABdhPJx+vPTMXgGqXUfLGXSmTwUGiHqJ1pGXF30jVnvKd2Kzjtnaau7tvdWmbper+dTMFbKEvw9Duw== X-Received: by 2002:a62:54c4:0:b029:142:2501:34d3 with SMTP id i187-20020a6254c40000b0290142250134d3mr871545pfb.44.1601919473565; Mon, 05 Oct 2020 10:37:53 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id f17sm533028pfq.141.2020.10.05.10.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 10:37:53 -0700 (PDT) From: Moritz Fischer To: linux-fpga@vger.kernel.org Subject: [PATCH v2 08/10] fpga: fpga-mgr: xilinx-spi: Simplify registration Date: Mon, 5 Oct 2020 10:37:33 -0700 Message-Id: <20201005173735.162408-9-mdf@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005173735.162408-1-mdf@kernel.org> References: <20201005173735.162408-1-mdf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_133754_369830_3CA051C9 X-CRM114-Status: GOOD ( 14.18 ) X-Spam-Score: 0.5 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.210.171 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.171 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [moritz.fischer.private[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, trix@redhat.com, michal.simek@xilinx.com, matthew.gerlach@intel.com, linux-kernel@vger.kernel.org, Moritz Fischer , linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/xilinx-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c index 824abbbd631e..27defa98092d 100644 --- a/drivers/fpga/xilinx-spi.c +++ b/drivers/fpga/xilinx-spi.c @@ -259,18 +259,7 @@ static int xilinx_spi_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int xilinx_spi_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(&spi->dev, mgr); } static const struct of_device_id xlnx_spi_of_match[] = { @@ -285,7 +274,6 @@ static struct spi_driver xilinx_slave_spi_driver = { .of_match_table = of_match_ptr(xlnx_spi_of_match), }, .probe = xilinx_spi_probe, - .remove = xilinx_spi_remove, }; module_spi_driver(xilinx_slave_spi_driver)