From patchwork Wed Oct 14 14:52:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 11837917 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 43D0B14B2 for ; Wed, 14 Oct 2020 15:20:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07F2921582 for ; Wed, 14 Oct 2020 15:20:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aCGvIAQ1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="cebomU+7"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="jFRpPE0l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07F2921582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Subject:To:From:Date: Message-Id:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=dZWGJWpVeIZATaTRu7e2M3LLoYliF2296A/w6gTCUgE=; b=aCGvIAQ1ysCjf5NiVA6tQzLlU hDF9a3ozgsIGcvcgYibi4LHHIH4vys61xwjQFFKnMOVifwrMMXDGCZGtrCUm0v737nkGxRJDACyUw /l+raRWJCzaV/IbebARJi0vqRGxTYechlxx6xC33/iVMQXQen/8oprwR5y6XsgotiZAicMy8Pt3Ph XW9vA1ZAhsoziKx/Qkk1lHbeGxNemUQb8gGAH6mIV5IdK1jvtr55OCoR5HXq2L9JbK9P/J1C2llwV Ww7jhUXpffANmG93vaE1Xq8ZYZI3zPS4DmgwHgO8voBPnJA2L1MdJ9SzeE6nAG17TIG7IEOmc96bX Rlwpvpy8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiZB-0005M7-S2; Wed, 14 Oct 2020 15:19:49 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiYK-0004zU-En for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 15:19:03 +0000 Message-Id: <20201014145727.828083323@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602688735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=N32D1F03swzHfdGQ4x5b3zezLn/pWbqF1oQiqUx5Yvo=; b=cebomU+72lP/7bhe6Jo/6wDxF4V+B8qyPAxeAY1e4qHf3C5zUd86KxnQOqxg9754PzOkxa We2qXfrln4z5Jwqv6Y8thXyVNihI4+Ki3PDDPxEz2nVkYoqxAycIqSSXsK/JTqzx3MoHVv 9mNLKYiVS7j7av9Q4POnGvrvO/yszXHwQi4xcs2Pn1e5qt+NkpKhxb9rUqDn5fLBBh7KzQ DGBibp3t0PnqcORy6fTg8ZQCqOGMlRvnTbvkRA18twwlMP+q3dv2QhK9go2OMr8ccmyKBB u8a406W37NKn0x6BqR9xazSMTF0gfilJAnfgGNL0aYUMLd2vhfhAkwQOE05B7w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602688735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=N32D1F03swzHfdGQ4x5b3zezLn/pWbqF1oQiqUx5Yvo=; b=jFRpPE0lhJTYJiqmHYSFF9Ug9ydzyJpzzI3Z+EtVqru8wzTkQNxS7OBWTr7nbPdd0Z9H9N wmxJdAX+zfsty5Bg== Date: Wed, 14 Oct 2020 16:52:22 +0200 From: Thomas Gleixner To: LKML Subject: [patch 07/12] usbip: Remove in_interrupt() check References: <20201014145215.518912759@linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_111856_673110_569E3690 X-CRM114-Status: GOOD ( 10.29 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [193.142.43.55 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, Valentina Manea , Krzysztof Kozlowski , Johan Hovold , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Alan Stern , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Ahmed S. Darwish The usage of in_interrupt() in drivers is phased out and Linus clearly requested that code which changes behaviour depending on context should either be separated or the context be conveyed in an argument passed by the caller, which usually knows the context. usbip_recv() uses in_interrupt() to conditionally print context information for debugging messages. The value is zero as the function is only called from various *_rx_loop() kthread functions. Remove it. Signed-off-by: Ahmed S. Darwish Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Valentina Manea Cc: Shuah Khan Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Acked-by: Shuah Khan --- drivers/usb/usbip/usbip_common.c | 5 ----- 1 file changed, 5 deletions(-) --- a/drivers/usb/usbip/usbip_common.c +++ b/drivers/usb/usbip/usbip_common.c @@ -324,11 +324,6 @@ int usbip_recv(struct socket *sock, void } while (msg_data_left(&msg)); if (usbip_dbg_flag_xmit) { - if (!in_interrupt()) - pr_debug("%-10s:", current->comm); - else - pr_debug("interrupt :"); - pr_debug("receiving....\n"); usbip_dump_buffer(buf, size); pr_debug("received, osize %d ret %d size %zd total %d\n",