| Message ID | 20201019045026.10732-1-billy_tsai@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpio: aspeed: fix ast2600 bank properties | expand |
On Mon, 19 Oct 2020, at 15:20, Billy Tsai wrote: > GPIO_T is mapped to the most significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_T is input only. All > the other bits need to be 1 because GPIO_Q/R/S support both input and > output modes. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Good catch, thanks Billy. Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Mon, Oct 19, 2020 at 6:50 AM Billy Tsai <billy_tsai@aspeedtech.com> wrote: > > GPIO_T is mapped to the most significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_T is input only. All > the other bits need to be 1 because GPIO_Q/R/S support both input and > output modes. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- > drivers/gpio/gpio-aspeed.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > index d07bf2c3f136..f24754b3f6d1 100644 > --- a/drivers/gpio/gpio-aspeed.c > +++ b/drivers/gpio/gpio-aspeed.c > @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config = > > static const struct aspeed_bank_props ast2600_bank_props[] = { > /* input output */ > + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */ > {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ > {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ > { }, > -- > 2.17.1 > Applied to fixes with reviews collected and added the Fixes: tag. Bartosz
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index d07bf2c3f136..f24754b3f6d1 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config = static const struct aspeed_bank_props ast2600_bank_props[] = { /* input output */ + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */ {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ { },
GPIO_T is mapped to the most significant byte of input/output mask, and the byte in "output" mask should be 0 because GPIO_T is input only. All the other bits need to be 1 because GPIO_Q/R/S support both input and output modes. Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> --- drivers/gpio/gpio-aspeed.c | 1 + 1 file changed, 1 insertion(+)