From patchwork Mon Oct 19 10:06:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 11844045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773C0C433E7 for ; Mon, 19 Oct 2020 10:22:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3CD62225A for ; Mon, 19 Oct 2020 10:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0me/FU/9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4lpNzGZt"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="L1BAx4Oy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3CD62225A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Subject:To:From:Date: Message-Id:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=9PoMNUGtjFmavZ4myHb7BSw18UD3P/vtdzBINg3qm1E=; b=0me/FU/9q2lRGH9hku/2woaqk kOQnMCyG8n2OXQIINtcvz6MykDTG80u9OsBIGYnB2DHjCUCGp1mHDhHaPDiOevoUGNuG+DLoh78vm Q3VQ7OtSpRlmphgG+OiN0hwN/lz9Bxol1Q9c8pzbQ/ILpeHi7v1qgKU97nlGatc2s/NnzUx1yZ0VE K08xtRHYJ94Zustgb7evrQ/MGyUrYkKi8pOIfN2uluF3e+NYqL3jAUsMsXsnPYP99BEH95PbjQzH5 KYXj8wW7JEdlWCJY+x5LtImT0f7DwLvgVegzbWU97GdjEtS3yRJQV867ZtYKCnWeireDEb5OF/qrD F7za5b7ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUSHh-0003vd-F7; Mon, 19 Oct 2020 10:20:57 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUSF8-0002vs-Pq for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 10:18:27 +0000 Message-Id: <20201019101110.944939915@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1603102697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=CglHTuol1LH6Rq9Arw6I3q0kZXSSc/D44FpLqZfI5WA=; b=4lpNzGZte+JbLXJ83VGLllmO8p7ZgJPUbn2pEj3AWBlV6Kr6kMkordF9yNYiD+J0YfMNXF WrlseHROLQU+l/lbqigi2qTk9VAJ5y929pArYCx8cDTQAbouSa8PoPonAE8JjMfp1PBvEa chWrp8n1QbIhLVdUVFfL5aSRuMaJZJS8TTFH9PSpLmIHnfKarImStpf087juZuVGvW9vpy d8B+uITbEjquNSdDef0bc5zON2rSBuX0oqlrKnMDzU69dISQhvYlJeHwTtqk2u140cDa/H 3fgsgfkIGUmNcjOiSHyfjChDmTDZqoKfiozdWtZ8cgBRXPi6/SvEdu54WiqWbQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1603102697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=CglHTuol1LH6Rq9Arw6I3q0kZXSSc/D44FpLqZfI5WA=; b=L1BAx4OybAp6bDVli4bT4V41G4OGiBnmrb1bmCjWXg2vrs6Qc4FM9XNkkoVzYxoojOoBkj 1uEPNEpJBDmssyCw== Date: Mon, 19 Oct 2020 12:06:42 +0200 From: Thomas Gleixner To: LKML Subject: [patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment References: <20201019100629.419020859@linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_061819_058612_4A2DCB1F X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski , Valentina Manea , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Alan Stern , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org in_interrupt() is a pretty vague context description as it means: hard interrupt, soft interrupt or bottom half disabled regions. Replace the vague comment with a proper reasoning why spin_lock_irqsave() needs to be used. Signed-off-by: Ahmed S. Darwish Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Duncan Sands Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Duncan Sands --- drivers/usb/atm/usbatm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/atm/usbatm.c +++ b/drivers/usb/atm/usbatm.c @@ -249,7 +249,7 @@ static void usbatm_complete(struct urb * /* vdbg("%s: urb 0x%p, status %d, actual_length %d", __func__, urb, status, urb->actual_length); */ - /* usually in_interrupt(), but not always */ + /* Can be invoked from task context, protect against interrupts */ spin_lock_irqsave(&channel->lock, flags); /* must add to the back when receiving; doesn't matter when sending */