diff mbox series

pinctrl: remove unneeded break

Message ID 20201019190055.7371-1-trix@redhat.com (mailing list archive)
State New, archived
Headers show
Series pinctrl: remove unneeded break | expand

Commit Message

Tom Rix Oct. 19, 2020, 7 p.m. UTC 
From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Andy Shevchenko Oct. 19, 2020, 7:22 p.m. UTC | #1 
On Mon, Oct 19, 2020 at 10:04 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return

When it's a single driver, use the proper prefix in the Subject line.

Also use proper English punctuation, i.e. period at the end of commit message.

>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> index 5e24838a582f..2223ead5bd72 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> @@ -108,19 +108,14 @@ static int s3c24xx_eint_get_trigger(unsigned int type)
>         switch (type) {
>         case IRQ_TYPE_EDGE_RISING:
>                 return EINT_EDGE_RISING;
> -               break;
>         case IRQ_TYPE_EDGE_FALLING:
>                 return EINT_EDGE_FALLING;
> -               break;
>         case IRQ_TYPE_EDGE_BOTH:
>                 return EINT_EDGE_BOTH;
> -               break;
>         case IRQ_TYPE_LEVEL_HIGH:
>                 return EINT_LEVEL_HIGH;
> -               break;
>         case IRQ_TYPE_LEVEL_LOW:
>                 return EINT_LEVEL_LOW;
> -               break;
>         default:
>                 return -EINVAL;
>         }
> --
> 2.18.1
>
diff mbox series

Patch

diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
index 5e24838a582f..2223ead5bd72 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
@@ -108,19 +108,14 @@  static int s3c24xx_eint_get_trigger(unsigned int type)
 	switch (type) {
 	case IRQ_TYPE_EDGE_RISING:
 		return EINT_EDGE_RISING;
-		break;
 	case IRQ_TYPE_EDGE_FALLING:
 		return EINT_EDGE_FALLING;
-		break;
 	case IRQ_TYPE_EDGE_BOTH:
 		return EINT_EDGE_BOTH;
-		break;
 	case IRQ_TYPE_LEVEL_HIGH:
 		return EINT_LEVEL_HIGH;
-		break;
 	case IRQ_TYPE_LEVEL_LOW:
 		return EINT_LEVEL_LOW;
-		break;
 	default:
 		return -EINVAL;
 	}