From patchwork Tue Oct 20 13:07:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 11846917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B5CC433E7 for ; Tue, 20 Oct 2020 13:08:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C7C922265 for ; Tue, 20 Oct 2020 13:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gLCyAgNQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XzFSdpHp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C7C922265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cCWGbZ5pneXQq8j3WKD3BVffZH6t6gyGMLqX9/xjW18=; b=gLCyAgNQRpjqzUJ0Uoa2CZMQI8 Yg+xV+Qn7w0SeY1SD6AYka2OyTAxwk0br3ylMBftV/AmgmVJ6XenKdpM7KAJ7fFtWZajiDAv6yquh lJ0SBIurnvKXbRMQ2uBu5tpy4VlYxgkYcyNgl1nK/6NnOkAr0gScWW7TjkdH2/LB4t5M6N800vZWh LPp9ZQOEJiHGDSZ7xEykoNi6TMl2yiT7b0TQTaPDeXB+J2w2sHGouREMDiTFLNNOJTTk112JEPHaD ZVD2OliBy1LtluGtq2Uoa1RkyS0fHhHIHdfnMm/yxj5iIH4pAdrb43MVAX8iYonY+pxsvU5ZCsbi9 IPhAkdqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUrMJ-00088f-0F; Tue, 20 Oct 2020 13:07:23 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUrMF-00087K-Lf for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 13:07:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603199239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=2anAzapiudNNR8XpuCb8etqjbkocHf/cArg3i1fKpjA=; b=XzFSdpHppG2FL08KYFei4bAoDixqrxFD5BS/ST9HhB9gFTVaid/yYcBYZB4h/26WL/EjjB HifkcvAgvFR++GRKuLvTyfaSpVDEypJlB0N6BtqveZ/0h9eO4tpt21QSgTl/CJfkwRTdDe DitY+ik8PkdR63gBwhWL7Zxi7gEu/Ok= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-VUASvnZDMmmgT6NEk53yew-1; Tue, 20 Oct 2020 09:07:16 -0400 X-MC-Unique: VUASvnZDMmmgT6NEk53yew-1 Received: by mail-qt1-f197.google.com with SMTP id t4so1509398qtd.23 for ; Tue, 20 Oct 2020 06:07:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2anAzapiudNNR8XpuCb8etqjbkocHf/cArg3i1fKpjA=; b=OBgiLy7paNsDrBmUqAf35VR2ke+w2lGsj1SQN13Ldw0I0H2pcLq948X6OsLQSCZjLx TXWmt+LVcvJfxmi1jhgZIDxYA/qiQQi1CtNesvW4gn7rleNguAPaWZuLQtUz/bjbv7qy HJYpBcFfnXm0UtTTKQryUkVKTxLf0dmPGjlr2VDicjZT0W194TB4dJOpJMeS/Nx6XhhZ zSXKqQZq8B3HA/koalrrCLv3PH/C6k8Z4dADeFyxQ/GL9C5QTOVz+NLTevVjtgNzavhc BHLAnL1bGCWM/Lksd9J7QdRzEzYlsZwDT9j0T19MuMGFd2AJ9WvnRYiasyLDiDZ8XUti Qhrw== X-Gm-Message-State: AOAM533ljvOUwn3u7+xguxSolia+76BwgP6Q/EwGN+uP26UaOn/tsoRk kZTxvjTgQg/1I5YCvWeqTamKrlObISpfV6hvn+NBADgpZY2i0aPp8M568SZmxFxy0pg/lkK88y7 0IORUNp0mcO9anQWuKa+HwA8mUAb27KAYypE= X-Received: by 2002:aed:216b:: with SMTP id 98mr2299348qtc.233.1603199234960; Tue, 20 Oct 2020 06:07:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqNg7p1DO3AxkYDn6Hv+sy3YgDE6VecvNiBWMxgWFr77Yf6Q7cXLbaArbHxGEA5CBuDcGZyg== X-Received: by 2002:aed:216b:: with SMTP id 98mr2299314qtc.233.1603199234669; Tue, 20 Oct 2020 06:07:14 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id 8sm760540qkm.0.2020.10.20.06.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2020 06:07:14 -0700 (PDT) From: trix@redhat.com To: gregkh@linuxfoundation.org, jirislaby@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: [PATCH v2] tty: serial: imx: remove unneeded break Date: Tue, 20 Oct 2020 06:07:09 -0700 Message-Id: <20201020130709.28096-1-trix@redhat.com> X-Mailer: git-send-email 2.18.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_090719_754074_4AB8F837 X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Rix , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tom Rix A break is not needed if it is preceded by a return Signed-off-by: Tom Rix --- v2: improve commit log --- drivers/tty/serial/imx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) switch (offset) { case UCR1: return sport->ucr1; - break; case UCR2: /* * UCR2_SRST is the only bit in the cached registers that might @@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) if (!(sport->ucr2 & UCR2_SRST)) sport->ucr2 = readl(sport->port.membase + offset); return sport->ucr2; - break; case UCR3: return sport->ucr3; - break; case UCR4: return sport->ucr4; - break; case UFCR: return sport->ufcr; - break; default: return readl(sport->port.membase + offset); }