diff mbox series

[v2] pinctrl: samsung: pinctrl-s3c24xx: remove unneeded break

Message ID 20201020131520.29117-1-trix@redhat.com (mailing list archive)
State New, archived
Headers show
Series [v2] pinctrl: samsung: pinctrl-s3c24xx: remove unneeded break | expand

Commit Message

Tom Rix Oct. 20, 2020, 1:15 p.m. UTC 
From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return.

Signed-off-by: Tom Rix <trix@redhat.com>
---

v2: Improve commit log

---
 drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Krzysztof Kozlowski Oct. 26, 2020, 7:18 p.m. UTC | #1 
On Tue, Oct 20, 2020 at 06:15:20AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> A break is not needed if it is preceded by a return.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> 
> v2: Improve commit log

Thanks, applied.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
index 5e24838a582f..2223ead5bd72 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
@@ -108,19 +108,14 @@  static int s3c24xx_eint_get_trigger(unsigned int type)
 	switch (type) {
 	case IRQ_TYPE_EDGE_RISING:
 		return EINT_EDGE_RISING;
-		break;
 	case IRQ_TYPE_EDGE_FALLING:
 		return EINT_EDGE_FALLING;
-		break;
 	case IRQ_TYPE_EDGE_BOTH:
 		return EINT_EDGE_BOTH;
-		break;
 	case IRQ_TYPE_LEVEL_HIGH:
 		return EINT_LEVEL_HIGH;
-		break;
 	case IRQ_TYPE_LEVEL_LOW:
 		return EINT_LEVEL_LOW;
-		break;
 	default:
 		return -EINVAL;
 	}