| Message ID | 20201022211301.3548422-1-jernej.skrabec@siol.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: allwinner: a64: Pine64 Plus: Fix ethernet node | expand |
On Thu, Oct 22, 2020 at 11:13:01PM +0200, Jernej Skrabec wrote: > According to board schematic, PHY provides both, RX and TX delays. > However, according to "fix" Realtek provided for this board, only TX > delay should be provided by PHY. > Tests show that both variants work but TX only PHY delay works > slightly better. > > Update ethernet node to reflect the fact that PHY provides TX delay. > > Fixes: 94f442886711 ("arm64: dts: allwinner: A64: Restore EMAC changes") > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Queued as a fix for 5.10, thanks! Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts index b26181cf9095..b54099b654c8 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts @@ -13,7 +13,7 @@ / { &emac { pinctrl-names = "default"; pinctrl-0 = <&rgmii_pins>; - phy-mode = "rgmii"; + phy-mode = "rgmii-txid"; phy-handle = <&ext_rgmii_phy>; status = "okay"; };
According to board schematic, PHY provides both, RX and TX delays. However, according to "fix" Realtek provided for this board, only TX delay should be provided by PHY. Tests show that both variants work but TX only PHY delay works slightly better. Update ethernet node to reflect the fact that PHY provides TX delay. Fixes: 94f442886711 ("arm64: dts: allwinner: A64: Restore EMAC changes") Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)