From patchwork Thu Oct 29 16:45:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11866881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13662C4363A for ; Thu, 29 Oct 2020 16:47:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CFF720825 for ; Thu, 29 Oct 2020 16:47:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rTDenHqt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dw6uRNa5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFF720825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=911/ATldgBqEeTEfEs5OfxQJCVhQC70RqpR2PNAcflA=; b=rTDenHqt+lPL1YQ4GeqHqSnMO tD1ZZlfx32o1JuEer8iwpYRSIJvJN33Hzu/Qr2bjR+DTPR+FdWCx7IsxwNQaJqY6C4r3NpRFZmnWN DSx9WOZnqgpqbiR1F5tqL/xnpDpGosvJfLT251xnT6Va+DZTFzlYJoxSQrsEvzeI+AXRQUDzenOVz iikQaE61TkSf+7fH/myayjWd0dfG1lb7k3sphS5AraAK3LU1g0Llqor/YabV7rqmQXVJ4Y0jtPkKW RPJOeyzFuyBFLIU+IF20pndn7WpB12unx3Jl5RA/5WjPxHnc3Y7BeLEToOq1e82MvtLNwbc4Veusl pVwfcbuXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYB40-00009X-42; Thu, 29 Oct 2020 16:46:12 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYB3s-00007n-J8 for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 16:46:05 +0000 Received: by mail-pg1-x544.google.com with SMTP id o3so2795590pgr.11 for ; Thu, 29 Oct 2020 09:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Np2c0Q4BDShbRLU/V5l//Z0ajqNMYgtNQNvz5k3aXQ0=; b=dw6uRNa5JlCe+v2CzEKP9981nPUUpS0430nUVSDjOsCMan7OPxQ+l2+Ijcyhs9j7Ye vGDxJiij3l6yx3ENZkBy1zpjYW6pbNFJR6/M4yrIGiNIMSiMQ+5SMFHxvgSyVo/245KT N1oFjncGsVdYH2g130qJhQXyoJPfUF8Kk2FiC1A68OwyikSSS+hdtPm7Bm3O6Q59iizi bySBDnhNTITUAdyKQfSU4mzhcy4g8m189ujExL5OOZCZILg9EFFHVpoQ5YpeuxVI4a4L kB5ieKFRKBZ0LI55isPmqNkQkoDYkOfTiFb/d8nlQtpCrsByOr6zH1ANhCNgxvzgAzlf FbGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Np2c0Q4BDShbRLU/V5l//Z0ajqNMYgtNQNvz5k3aXQ0=; b=X5lBqkAS6FXmkie8dKzTPoearCLfwiW5p5YFg3c7G5bsXA9B20tpbc8H1/SvQTgarV JAVcX0CyeBOy0E3X2OcbPnL0Tb0WprQBP/8IHa/hUcuiqNtS9QUIumjlcDgqNClCi44f dlVzel2Z6PIEJZVlRVoMnqr6hfxazAIKXi59OHLhu5gV6cw5aBIPkq1StE2BUtCKI6un v313OBLmpwjJYRSyty57N223hhXKWXkDCIgESTQHwhFzRHlDfCrCTD84yKip4eTHv+G/ tGb6HGPgWxWu85nFtmZZGTqYFuMTLBmX8MYmHdyHBm8rv6L9B/h9OIqYU4Ewyhsr7tv4 FbPA== X-Gm-Message-State: AOAM530NWSN//mj3H1l/G04rCVlMhsy++O4wBfzzMIyb0fZMFOTgAwka LaIgqiZf4RkSklbaBlHKyLQHaA== X-Google-Smtp-Source: ABdhPJzbyjuBN6oiLpw/o7n3U+L8YKB69Mc7zWaZrJeQRHfTiiAnESi+lfspOUgbhXl4svSQLX17eA== X-Received: by 2002:a17:90a:ec11:: with SMTP id l17mr25563pjy.104.1603989962354; Thu, 29 Oct 2020 09:46:02 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id b7sm3625415pfr.171.2020.10.29.09.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 09:46:01 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 1/2] coresight: cti: Initialize dynamic sysfs attributes Date: Thu, 29 Oct 2020 10:45:58 -0600 Message-Id: <20201029164559.1268531-2-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164559.1268531-1-mathieu.poirier@linaro.org> References: <20201029164559.1268531-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_124604_652127_C86AE559 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Suzuki K Poulose With LOCKDEP enabled, CTI driver triggers the following splat due to uninitialized lock class for dynamically allocated attribute objects. [ 5.372901] coresight etm0: CPU0: ETM v4.0 initialized [ 5.376694] coresight etm1: CPU1: ETM v4.0 initialized [ 5.380785] coresight etm2: CPU2: ETM v4.0 initialized [ 5.385851] coresight etm3: CPU3: ETM v4.0 initialized [ 5.389808] BUG: key ffff00000564a798 has not been registered! [ 5.392456] ------------[ cut here ]------------ [ 5.398195] DEBUG_LOCKS_WARN_ON(1) [ 5.398233] WARNING: CPU: 1 PID: 32 at kernel/locking/lockdep.c:4623 lockdep_init_map_waits+0x14c/0x260 [ 5.406149] Modules linked in: [ 5.415411] CPU: 1 PID: 32 Comm: kworker/1:1 Not tainted 5.9.0-12034-gbbe85027ce80 #51 [ 5.418553] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 5.426453] Workqueue: events amba_deferred_retry_func [ 5.433299] pstate: 40000005 (nZcv daif -PAN -UAO -TCO BTYPE=--) [ 5.438252] pc : lockdep_init_map_waits+0x14c/0x260 [ 5.444410] lr : lockdep_init_map_waits+0x14c/0x260 [ 5.449007] sp : ffff800012bbb720 ... [ 5.531561] Call trace: [ 5.536847] lockdep_init_map_waits+0x14c/0x260 [ 5.539027] __kernfs_create_file+0xa8/0x1c8 [ 5.543539] sysfs_add_file_mode_ns+0xd0/0x208 [ 5.548054] internal_create_group+0x118/0x3c8 [ 5.552307] internal_create_groups+0x58/0xb8 [ 5.556733] sysfs_create_groups+0x2c/0x38 [ 5.561160] device_add+0x2d8/0x768 [ 5.565148] device_register+0x28/0x38 [ 5.568537] coresight_register+0xf8/0x320 [ 5.572358] cti_probe+0x1b0/0x3f0 ... Fix this by initializing the attributes when they are allocated. Fixes: 3c5597e39812 ("coresight: cti: Add connection information to sysfs") Reported-by: Leo Yan Tested-by: Leo Yan Cc: Mike Leach Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-cti-sysfs.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c index 392757f3a019..7ff7e7780bbf 100644 --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c @@ -1065,6 +1065,13 @@ static int cti_create_con_sysfs_attr(struct device *dev, } eattr->var = con; con->con_attrs[attr_idx] = &eattr->attr.attr; + /* + * Initialize the dynamically allocated attribute + * to avoid LOCKDEP splat. See include/linux/sysfs.h + * for more details. + */ + sysfs_attr_init(con->con_attrs[attr_idx]); + return 0; }