| Message ID | 20201030005528.1017025-1-andrew@lunn.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: vf610-zii-dev-rev-b: Fix MDIO over clocking | expand |
Reviewed-by: Chris Healy <cphealy@gmail.com> On Thu, Oct 29, 2020 at 5:55 PM Andrew Lunn <andrew@lunn.ch> wrote: > > The ZII devel B board has two generations of Marvell Switches. The > mv88e6352 supports an MDIO clock of 12MHz. However the older 88e6185 > does not like 12MHz, and often fails to probe. > > Reduce the clock speed to 5MHz, which seems to work reliably. > > Cc: Chris Healy <cphealy@gmail.com> > Fixes: b955387667ec ("ARM: dts: ZII: update MDIO speed and preamble") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > index e500911ce0a5..6f1e0f0d4f0a 100644 > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts > @@ -406,6 +406,9 @@ i2c@4 { > }; > }; > > +&mdio1 { > + clock-frequency = <5000000>; > +}; > > &iomuxc { > pinctrl_gpio_e6185_eeprom_sel: pinctrl-gpio-e6185-eeprom-spi0 { > -- > 2.28.0 >
On Fri, Oct 30, 2020 at 01:55:28AM +0100, Andrew Lunn wrote: > The ZII devel B board has two generations of Marvell Switches. The > mv88e6352 supports an MDIO clock of 12MHz. However the older 88e6185 > does not like 12MHz, and often fails to probe. > > Reduce the clock speed to 5MHz, which seems to work reliably. > > Cc: Chris Healy <cphealy@gmail.com> > Fixes: b955387667ec ("ARM: dts: ZII: update MDIO speed and preamble") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Applied, thanks.
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts index e500911ce0a5..6f1e0f0d4f0a 100644 --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts @@ -406,6 +406,9 @@ i2c@4 { }; }; +&mdio1 { + clock-frequency = <5000000>; +}; &iomuxc { pinctrl_gpio_e6185_eeprom_sel: pinctrl-gpio-e6185-eeprom-spi0 {
The ZII devel B board has two generations of Marvell Switches. The mv88e6352 supports an MDIO clock of 12MHz. However the older 88e6185 does not like 12MHz, and often fails to probe. Reduce the clock speed to 5MHz, which seems to work reliably. Cc: Chris Healy <cphealy@gmail.com> Fixes: b955387667ec ("ARM: dts: ZII: update MDIO speed and preamble") Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 +++ 1 file changed, 3 insertions(+)