From patchwork Wed Nov 4 15:57:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Codrin Ciubotariu X-Patchwork-Id: 11881333 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F2DC2D0A3 for ; Wed, 4 Nov 2020 15:58:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 338D52063A for ; Wed, 4 Nov 2020 15:58:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iBCCbShh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="vsez/aQZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 338D52063A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=+uJkhDucvyTUozeiWRY+s3iy6V+b+qFXLeygw2F6Tlo=; b=iBCCbShhLoy/2zmFqb8qAtzbOX kRQTKPDdffPeJNKZRk6btqk4F0cJP5L7YERdFRaefowMhMbjFfOEKgkscn5WjsW55nV+iEe7Nensr Lt6mJv92ceekiRI0+PA07nrW5h7emUTEZ6LaSlWGqU4hpqcgQyirhvzgSe7L/WuTtYNshScLff6Xr NFgxNbVyWEhy4vAUzv9qg7k24dNUy5g9RKfDiL/0n6SgR5WCtnsfmyy4KEXtkyWJheP8L0fxlUSbD QIgJql49hcrahmmLZegindmQy9x1fKOqorPmb8ALmsVgEE2A/ZQ1uUTN88A48fwTQImnPVu3NLPzM ZxHHH08Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaLAW-0007X6-CW; Wed, 04 Nov 2020 15:57:52 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaLAS-0007VK-Ny for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 15:57:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1604505468; x=1636041468; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1IXMDBOSCtaUZtiq9izDv17V26Pq9aWYb9Tw2O2fSxs=; b=vsez/aQZ3w6JdVtZF3lYsutrcP9lgbeciYlBnPl2I2s5vBO2CFJV2OkY zbktNSxoCEdRKv8t0sTofKUoMpw+Cce8OQavK07mxAay4jB1WQVPT1PY3 QHuHdeEtAJMD4Lp/akBsRUh6qtZNZ1Ke416P7tQ+A+SyBNOJfHiKXePqW kVlM49kZPopPvxg6gOu+keQR6vuawz2CNHumb+5nLjnYoEXYMmfAeSD4v krYTJniogMS10i/FxHZ6lgM4U0hsHSqgitamjcdcyLYVG3bfd9fXG1vD7 cKcCjtZdaxOm8J+JPUe58ofnGd3/ZfzPruwG6tazRWdtenxN0L2SzqeAX Q==; IronPort-SDR: xmQk0RwZowrJeY6M1qYOR3nH7hBq/SFUF+bH3yXO4jsDjxPIRtmeRLh7IyMcx7f6vJBgDyTWtZ RL+ojKFAhSPa9MMv9a5RpWmut69xdcwpz2KEwJKNIZPIJ7Xg2uHhsB+bkwtBjZmvS7GGN/MyZI jcBtIJdLz50OLYiZ8D9JLvgHJzmXrsrnGhGoIVNhhbiNe5TdtWZgP+HMRPIaE0P4hkjyawhySB Cms0meRnCremStsCaNiNIIoqHTRHw477jNBZQG58GwARmfW2C3d/N3/5py9k74aHAtlsQzF7LY F40= X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="32405234" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 Nov 2020 08:57:44 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 4 Nov 2020 08:57:43 -0700 Received: from rob-ult-m19940.amer.actel.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 4 Nov 2020 08:57:40 -0700 From: Codrin Ciubotariu To: , , Subject: [PATCH] ASoC: mchp-spdiftx: Do not set Validity bit(s) Date: Wed, 4 Nov 2020 17:57:38 +0200 Message-ID: <20201104155738.68403-1-codrin.ciubotariu@microchip.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_105748_947929_4192E435 X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, lgirdwood@gmail.com, ludovic.desroches@microchip.com, broonie@kernel.org, Codrin Ciubotariu Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Validity bits (bit 28) must not be set in order to have the samples valid. Some controllers look for this bit and ignore the samples if it is set. Fixes: 06ca24e98e6b ("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller") Signed-off-by: Codrin Ciubotariu --- sound/soc/atmel/mchp-spdiftx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/atmel/mchp-spdiftx.c b/sound/soc/atmel/mchp-spdiftx.c index 82c1eecd2528..3bd350afb743 100644 --- a/sound/soc/atmel/mchp-spdiftx.c +++ b/sound/soc/atmel/mchp-spdiftx.c @@ -487,7 +487,6 @@ static int mchp_spdiftx_hw_params(struct snd_pcm_substream *substream, } mchp_spdiftx_channel_status_write(dev); spin_unlock_irqrestore(&ctrl->lock, flags); - mr |= SPDIFTX_MR_VALID1 | SPDIFTX_MR_VALID2; if (dev->gclk_enabled) { clk_disable_unprepare(dev->gclk);