| Message ID | 20201107133926.37187-2-pawel.mikolaj.chmiel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] arm64: dts: exynos: Include common syscon restart/poweroff for Exynos7 | expand |
On Sat, Nov 07, 2020 at 02:39:26PM +0100, Paweł Chmiel wrote: > It's not possible to reboot or poweroff Exynos7420 using PSCI. Instead > we need to use syscon reboot/poweroff drivers, like it's done for other > Exynos SoCs. This was confirmed by checking vendor source and testing it > on Samsung Galaxy S6 device based on this SoC. > > To be able to use custom restart/poweroff handlers instead of PSCI > functions, we need to correct psci compatible. This also requires us to > provide function ids for CPU_ON and CPU_OFF. > > Fixes: fb026cb65247 ("arm64: dts: Add reboot node for exynos7") > Fixes: b9024cbc937d ("arm64: dts: Add initial device tree support for exynos7") > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Changes from v1: > - Split into two separate patches. > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, applied. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 723f5d5fcf00..fff383206545 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -117,8 +117,10 @@ cpu_atlas3: cpu@3 { }; psci { - compatible = "arm,psci-0.2"; + compatible = "arm,psci"; method = "smc"; + cpu_off = <0x84000002>; + cpu_on = <0xC4000003>; }; soc: soc@0 {
It's not possible to reboot or poweroff Exynos7420 using PSCI. Instead we need to use syscon reboot/poweroff drivers, like it's done for other Exynos SoCs. This was confirmed by checking vendor source and testing it on Samsung Galaxy S6 device based on this SoC. To be able to use custom restart/poweroff handlers instead of PSCI functions, we need to correct psci compatible. This also requires us to provide function ids for CPU_ON and CPU_OFF. Fixes: fb026cb65247 ("arm64: dts: Add reboot node for exynos7") Fixes: b9024cbc937d ("arm64: dts: Add initial device tree support for exynos7") Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> --- Changes from v1: - Split into two separate patches. --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)