diff mbox series

[v2] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target

Message ID 20201108191614.4062210-1-natechancellor@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target | expand

Commit Message

Nathan Chancellor Nov. 8, 2020, 7:16 p.m. UTC
While running 'make dtbs_install', the following error occurs:

make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install'.

It should be .dtb, not .dts.

Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---

v1 -> v2:

* Simplify commit message and error (Krzysztof).
* Pick up Krzysztof's tag.

 arch/arm64/boot/dts/freescale/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 39fabe22e0f8c00334882ceac1dc70ffbd7f4871

Comments

Frieder Schrempf Nov. 9, 2020, 8:05 a.m. UTC | #1
On 08.11.20 20:16, Nathan Chancellor wrote:
> While running 'make dtbs_install', the following error occurs:
> 
> make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install'.
> 
> It should be .dtb, not .dts.
> 
> Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Thanks for fixing my error!
I often use Yocto to build the kernel and it doesn't use "make dtbs", 
but reference single dtbs directly by its name. I probably should have 
tested this more properly.

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

> ---
> 
> v1 -> v2:
> 
> * Simplify commit message and error (Krzysztof).
> * Pick up Krzysztof's tag.
> 
>   arch/arm64/boot/dts/freescale/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 876bf484bbe6..6f0777ee6cd6 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
>   dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
>   dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
>   dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> -dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
>   dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
>   dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
>   dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
> 
> base-commit: 39fabe22e0f8c00334882ceac1dc70ffbd7f4871
>
Shawn Guo Nov. 10, 2020, 3:03 a.m. UTC | #2
On Sun, Nov 08, 2020 at 12:16:15PM -0700, Nathan Chancellor wrote:
> While running 'make dtbs_install', the following error occurs:
> 
> make[3]: *** No rule to make target 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by '__dtbs_install'.
> 
> It should be .dtb, not .dts.
> 
> Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 876bf484bbe6..6f0777ee6cd6 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -32,7 +32,7 @@  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
-dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb