From patchwork Fri Nov 13 15:28:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ahmad Fatoum X-Patchwork-Id: 11903953 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61FBC55ABD for ; Fri, 13 Nov 2020 15:29:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A4BD20691 for ; Fri, 13 Nov 2020 15:29:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0oQ1kDF8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A4BD20691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=RttEW6XQeKT8TsxseAxSnn8oaCkBrYxypmbWxCGrubo=; b=0oQ1kDF8rQc/H+CC++/iToR+Vz YYmLhuRUtG8f8wM3bwwBqA3eXbVhcdnYIu3SGhgytg6sPxC8iMXbZlEGZN44cTuzxdf5xfpeCDtC0 PV7XdrppivzNB8fdr7XfuyPW4yFZUorTZg2bTW8J2YGr6dLkVatWiHNs5dRnK9Qmq3VbM27hAk7JS 7PoKbJStWP8UmtanUhfQjeSohVWxjPoOl2qyN0M3uPFLRRQO1Vupt95ZygTk8FHJ7ieOqoSu6Jrr3 nGxZfLGw8nK+dpctLi07TBEGY9U6J9dJT80DBbU7bmGOXx7AvNxDuiNt9rEKsv2I+jbkyeD/Med7C xtyLAfmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdb0h-0003wk-SG; Fri, 13 Nov 2020 15:29:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdb0b-0003vB-L0 for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 15:29:07 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdb0V-0005ZU-Sx; Fri, 13 Nov 2020 16:28:59 +0100 Received: from afa by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kdb0V-0000zk-2g; Fri, 13 Nov 2020 16:28:59 +0100 From: Ahmad Fatoum To: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [RFC PATCH] ARM: dts: imx6qdl: specify vcc-supply for NOP USB PHYs Date: Fri, 13 Nov 2020 16:28:55 +0100 Message-Id: <20201113152856.3758-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: afa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_102905_858883_5DADCF04 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Ahmad Fatoum , linux-arm-kernel@lists.infradead.org, Frieder Schrempf , linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The SoC dtsi lists a NOP USB PHY for each of the two HSIC-only USB controllers. Their device tree node doesn't indicate a vcc-supply resulting in: usb_phy_generic usbphynop1: supply vcc not found, using dummy regulator usb_phy_generic usbphynop2: supply vcc not found, using dummy regulator warnings on boot up. The USB IP vcc-supply - separate from the vusb - is hardwired to LDO_2P5[1], which we already have a device tree node for. Reference it for the dummy "phy" as well. This will lead to breakage (probe deferment) for kernels that: - Use a HSIC USB controller - Use this new device tree - but have CONFIG_REGULATOR_ANATOP disabled Because while the regulator is always-on, it can't be resolved when there is no driver for it. As there are - no affected upstream device trees - existing device trees are unaffected without recompilation - disabling CONFIG_REGULATOR_ANATOP is explicitly a non-recommended configuration per symbol help text this potential breakage is deemed acceptable. [1]: i.MX 6Dual/6Quad Reference Manual, Rev. C, Figure 53-1. Power System Overview Cc: Frieder Schrempf Signed-off-by: Ahmad Fatoum --- arch/arm/boot/dts/imx6qdl.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 43edbf1156c7..22e4c142de13 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -131,11 +131,13 @@ pmu: pmu { usbphynop1: usbphynop1 { compatible = "usb-nop-xceiv"; + vcc-supply = <®_vdd2p5>; #phy-cells = <0>; }; usbphynop2: usbphynop2 { compatible = "usb-nop-xceiv"; + vcc-supply = <®_vdd2p5>; #phy-cells = <0>; };