From patchwork Wed Nov 25 19:24:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 11932095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_TVD_MIME_NO_HEADERS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E57CC56201 for ; Wed, 25 Nov 2020 19:26:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A12E62075A for ; Wed, 25 Nov 2020 19:26:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rRE2dscL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="R1aVelA7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A12E62075A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:MIME-Version: Cc:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LpsDW1aY+ztpWEBoC5oeO6r7uVKV1NGugxme/5KlC6I=; b=rRE2dscLZbPfTGC5GnWwP/Dx5 WUnqzDQbxSuupbRubO02qk4NTLNy2+LgxP7RdOgqdDdTrCWKM/pXVaMUCVTUYHE0mRjjH+XggBDaY p0rGfcCi2U1tFZh5ZCMG8BK0M4krbnIBDMsG/bfN0AwuQzv1q2cklO0b1LrXmlAHTpeh95M1HJg9s hyefvt9hx3axCAwiRji+q3dD78raoa0te/nld2O5TZXvC0JEg8PreXObUFrqI7/XoxCl73vi+UgvD xNQvT2hlgxTMvxL6ROk0rNoQDc5EZSSLIhQ1baKz1br7qJxwN9IJVoyczLCS//yn8gmP5kXr0NEs5 QqsJcpG1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ki0Px-0007mB-U1; Wed, 25 Nov 2020 19:25:29 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ki0PJ-0007XZ-9f for linux-arm-kernel@lists.infradead.org; Wed, 25 Nov 2020 19:24:51 +0000 Received: by mail-pg1-x541.google.com with SMTP id k11so619476pgq.2 for ; Wed, 25 Nov 2020 11:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0nxY4iA+yXBWD5TvXuHojDkoiy4xC218NYJE6IGm+U0=; b=R1aVelA7+f7f/DBbBVIH54jFY6gfBxLd2shnDA+kEmm/5MFu26Hszt35SY0XR0u4nT JUuTZz20f8cxD1fvenuGdqGSQeyKyzier3p6JVyxBsb+2qM2N71SP1Uyl5MaXPjrHtnK wx1VhQTPW/2Up5WK8lhYgydsQtj8bpgwucjE8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0nxY4iA+yXBWD5TvXuHojDkoiy4xC218NYJE6IGm+U0=; b=REiqnKNRM+O7VL6sidtaobsxZ1DAZsRAr/iHuiD6yz6feqcQzbRj3roPn5TVhjwSdx bU0BZnpMAuvPMQP0Zd4QW/nPigSdaypDAincRz5mvx3IYD17xV5OOfsJyNCDNIpgrm8B GS9eNw/4zMEajQM4nEldEHDew2ryk+nFfYVKBWVhAVPOA/U32wXggtSvjYSDLbITRjTL eVaNwuavpaqFTauDKZv0dnW+jVTpWKGp9H5BA9erqlnuSpQxj020YvpmG3psK3LWaUAU 7C9T0lAR/2yuw8kSnWAPE0H54SakCo12YDe5nZrxIHLruZ9TWpk7tLfVqyyr6j8/5acq 1vpg== X-Gm-Message-State: AOAM5301I/pFfkdhS9Kw3vRCDtMm46LHhlT+hgm2EoJw+pfavYQpM7C2 4Lm55i2Sopz4aSlL8B1vHWAyOw== X-Google-Smtp-Source: ABdhPJzZB+z5HZ0U9Yq+r9Hs5Zij93+M5LaBi35+NENiriad4Dzsn20S54J8IQmFMiE+G0cuFg3aVw== X-Received: by 2002:a17:90a:ba84:: with SMTP id t4mr5062420pjr.110.1606332287495; Wed, 25 Nov 2020 11:24:47 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id j69sm2574885pfd.37.2020.11.25.11.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 11:24:46 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Subject: [PATCH v1 6/6] PCI: brcmstb: check return value of clk_prepare_enable() Date: Wed, 25 Nov 2020 14:24:23 -0500 Message-Id: <20201125192424.14440-7-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201125192424.14440-1-james.quinlan@broadcom.com> References: <20201125192424.14440-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201125_142449_506524_3806391F X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , open list , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The check was missing on PCIe resume. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 469bbb0ebdd9..56c88d2b4f87 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1380,7 +1380,9 @@ static int brcm_pcie_resume(struct device *dev) base = pcie->base; brcm_set_regulators(pcie, TURN_ON); - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; ret = brcm_phy_start(pcie); if (ret)