From patchwork Fri Nov 27 17:52:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11937005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51ACCC5519F for ; Fri, 27 Nov 2020 17:57:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4E3C2224A for ; Fri, 27 Nov 2020 17:57:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i3PGv3ok"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZOmulhzG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4E3C2224A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WKBIWfxQaPrhmlMSmWtBW/CSXw3sAOU90En/fpVDwqc=; b=i3PGv3okMip1NUgidxfRBi3+M 6xkkqu741R0gtAhywU51JdyqSXkRf/aZaTb9JiNaqZNc1xNWzoxuPERBrJmkdsTzqCkzQKDtoK+6O 9O1E9lQpFVkJ361CveUxMNuqhdUZE20OAADy+8XffSE7Anl4cn/+NgYr7RaxmcOS2UkPLvhDnsOFC d+JGdwvQKN870W34pdI07K2oTTFTI+dYorlK6vIbzBRP0PF0214HIP/nY8jXpadEOhjOStZte49iP 9NSf5Lx1/Mzr7MegiA7RooQoMu6KTszywGAm0l6To8yS6Sajmyx2onbIWX3UTwOY9kH0NUqERAhE7 gWuln6+wA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kihyB-0005gv-6w; Fri, 27 Nov 2020 17:55:43 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kihvk-0004fY-Pr for linux-arm-kernel@lists.infradead.org; Fri, 27 Nov 2020 17:53:15 +0000 Received: by mail-pf1-x442.google.com with SMTP id b10so3779182pfo.4 for ; Fri, 27 Nov 2020 09:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lzkQ7KjTmf9uNjmH2W4CF/NveH5gwN6iZCEtNMeWTEE=; b=ZOmulhzGbIEbaEmzl2irtH/N1ShGxJL6T5d8r+SvnP3WTI4N+cI5F+0A9PEDqjtx7t 2kXl2GDgWHS0Tk20x9uW8JDnWL+ubIUpAZr6BV1VKPGld/kpNKAmrIvByiMgyZnKHlBi S6oE/xDmM4Q74j+Pr0dvqUap828I6Uh8xGm1vHecXszKtvCqXhfKfPX+tB37XQea5LcJ LDKrdqULkZcLm7LUcEA3ygWi52eynYnPJIt9/xMj/IJPbxOY2RENnJF1B+7ufYzT2noV FkBGqZJnC1z8TJC2XstrrZLiRige8wmvaOuKkaATSu25JjFHWwrAO7YqkJQy3PmsK27t ynKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lzkQ7KjTmf9uNjmH2W4CF/NveH5gwN6iZCEtNMeWTEE=; b=Eoj7wu/lf4wHMu+PmYpB+kHG6BzKavvQteWw2Mnj6It45+WyetopR6jlpF6d59yYqa 5/KZ6Vlyyk2E0Qgw0f1is3JcB9EIhAK8WR1qntI8MmUxGeeYlJX0o7QJ6QK26dLAY656 saiH+pevxiGXpnsi8UtqbZcBXnQXsUB20eLWk8fXOKK2lZUgNwqFTO2+KDJ46DwJmPB/ 9sq8Fe8QsauXcJFaLs2uIAWB3GOD99FPlZh4/LPXs+QtcBxFhyMKP1P9yQZqSq/W+UfK LRgGCJrxvjnCEDh+0YiOA7m6FqPf54o/icshoe22jA4yeJCezNAsKnzyrXNUysGoniPo J9+A== X-Gm-Message-State: AOAM530nfuljhy6EOXNj072YgOnTB6aQiz8BXKemn5go4ui3z6K/QrZG qcB0V3ulpDRueZfWZ9gmtHygvrgnx1EATe8+ X-Google-Smtp-Source: ABdhPJx4WSZkOS6B0Ex8g/O/SFyMYlAm6FSrwBtntbL63U5cKhYc9cEzFiVtjN9erV+7wn0BxnuitA== X-Received: by 2002:a17:90a:4408:: with SMTP id s8mr11691745pjg.69.1606499591039; Fri, 27 Nov 2020 09:53:11 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t18sm10536724pji.1.2020.11.27.09.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 09:53:10 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 13/15] coresight: Fix W=1 warnings in core framework Date: Fri, 27 Nov 2020 10:52:54 -0700 Message-Id: <20201127175256.1092685-14-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201127175256.1092685-1-mathieu.poirier@linaro.org> References: <20201127175256.1092685-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_125312_936410_05BD9409 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CC drivers/hwtracing/coresight/coresight-etm4x-sysfs.o CC drivers/hwtracing/coresight/coresight-stm.o drivers/hwtracing/coresight/coresight-core.c:440: warning: Function parameter or member 'csdev' not described in 'coresight_disable_source' drivers/hwtracing/coresight/coresight-core.c:670: warning: Function parameter or member 'csdev' not described in 'coresight_get_ref' drivers/hwtracing/coresight/coresight-core.c:687: warning: Function parameter or member 'csdev' not described in 'coresight_put_ref' drivers/hwtracing/coresight/coresight-core.c:758: warning: Function parameter or member 'sink' not described in '_coresight_build_path' CC drivers/hwtracing/coresight/coresight-cpu-debug.o CC drivers/hwtracing/coresight/coresight-catu.o Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-core.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 29c83eac3106..4ba801dffcb7 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -432,7 +432,7 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode) * coresight_disable_source - Drop the reference count by 1 and disable * the device if there are no users left. * - * @csdev - The coresight device to disable + * @csdev: The coresight device to disable * * Returns true if the device has been disabled. */ @@ -663,6 +663,9 @@ struct coresight_device *coresight_get_sink_by_id(u32 id) /** * coresight_get_ref- Helper function to increase reference count to module * and device. + * + * @csdev: The coresight device to get a reference on. + * * Return true in successful case and power up the device. * Return false when failed to get reference of module. */ @@ -682,6 +685,8 @@ static inline bool coresight_get_ref(struct coresight_device *csdev) /** * coresight_put_ref- Helper function to decrease reference count to module * and device. Power off the device. + * + * @csdev: The coresight device to decrement a reference from. */ static inline void coresight_put_ref(struct coresight_device *csdev) { @@ -744,6 +749,7 @@ static void coresight_drop_device(struct coresight_device *csdev) /** * _coresight_build_path - recursively build a path from a @csdev to a sink. * @csdev: The device to start from. + * @sink: The final sink we want in this path. * @path: The list to add devices to. * * The tree of Coresight device is traversed until an activated sink is