From patchwork Mon Nov 30 21:11:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 11941319 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_TVD_MIME_NO_HEADERS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03455C64E7B for ; Mon, 30 Nov 2020 21:14:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91381206A5 for ; Mon, 30 Nov 2020 21:14:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zvMlEzGg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="NtIezV3X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91381206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:MIME-Version: Cc:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m8yR7nlns9KNKtpJwl5fKU73YrHkTWeirKZrPrGutBM=; b=zvMlEzGgZ1r41fhkNcipuWSOV o4bFSHIOp8uJasMGu251JLgIhvIfLYXU/FSPLVCzCzNdOHYkN6c1bGEV/GuUZOdy09hG1QS9sWNSW /mOIYB1mT7KY+hkCu7VByg5Kg6ket7hreWJa8f+C7s7RJs7C6Tsc7jp0vCC7IU7dLVUEbIPKAOwiE 1gXMpfI0DslAcKg1AEIpQMLT2aWfjPbxzgEbmiGcQf7EUNjHf8iZ4eRpDoFRLCG/KyNLtA+93lRiH SeukcTuQEOo+1nFgSaj3imISjlULLYp9CjXlSbYivMcHf6lqHIKFQDExQwyp3TYaTOBgxOY0ZGJHq EGsoqg+/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjqTu-0003MT-3t; Mon, 30 Nov 2020 21:13:10 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjqT0-00034n-R9 for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 21:12:16 +0000 Received: by mail-pf1-x444.google.com with SMTP id q10so11267968pfn.0 for ; Mon, 30 Nov 2020 13:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OlG+Ax0WajbFRZsSRshOO0gU0atXG14h4sybs64AuH4=; b=NtIezV3XK+db8Nr82xt7b1U3zH0etQwNaJ6VVuQ0Op+YHKKXOxGkXMNL6qDyVNe1QT 15JsGhKe5hWvHSBiLX/3Ix8Jv5NU50IMH4jUYDyu3Bl9C715mHU1EBzobe9rYlcRY4EB BotrGpg112IZ3ATS3Z3mcaD5eUksfnILEV1K0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OlG+Ax0WajbFRZsSRshOO0gU0atXG14h4sybs64AuH4=; b=EQPCq328IVnSZE72m4aoJp2oAza3CNXnPUP9cqXOzLjBw/Tyuh/76GkZW2CZtDgFNZ z+hkBXt3fu57TZG6sR7UiZivJJD8ZwPLBJYX5Ranrs52s2lPjHEdTblSVgsgQRV54J9j EEi97I5m8vsAbSTMYbh31NG4aheMgKJOLr8ojbsm6ArQEEz4ehaKFJ/daI8mRZmvCwxR eWg5dbBffrDndvUFsf/mw4/grRZkrc0e1XWMwJYoihu8Wa613qEIpGew2OVaxCHzvEGB JGpEhTgOe9z3opy3kv8+pvZWnC0QefFolGxZWsu+/mUyv1caXJPUAB/A4wwMIzuqB8QR ZxHg== X-Gm-Message-State: AOAM531WAd9rTPX+qAFN4FJdX0xULyVVTJecjCHyZYWBcnDJnKHGKIRg 9mGccA8/pnwi0kj4D+8B6YUSzA== X-Google-Smtp-Source: ABdhPJwnZhJZPf1dQz/a2JUEap4CRZ2bjRrjB7x9Fvg3sOSBstb1+LUHlYAkvj2a9XGY/mKZYYyMOw== X-Received: by 2002:a63:6dca:: with SMTP id i193mr13821834pgc.89.1606770732570; Mon, 30 Nov 2020 13:12:12 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id m7sm18320441pfh.72.2020.11.30.13.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 13:12:11 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , broonie@kernel.org, bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Subject: [PATCH v2 6/6] PCI: brcmstb: check return value of clk_prepare_enable() Date: Mon, 30 Nov 2020 16:11:43 -0500 Message-Id: <20201130211145.3012-7-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201130211145.3012-1-james.quinlan@broadcom.com> References: <20201130211145.3012-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_161214_982995_ABC9F02F X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , open list , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The check was missing on PCIe resume. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 3983d6c80769..64cf534e44d0 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1344,7 +1344,9 @@ static int brcm_pcie_resume(struct device *dev) base = pcie->base; brcm_set_regulators(pcie, TURN_ON); - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; ret = brcm_phy_start(pcie); if (ret)