From patchwork Thu Dec 3 02:23:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 11947561 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF556C6369E for ; Thu, 3 Dec 2020 02:25:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A7AB21D91 for ; Thu, 3 Dec 2020 02:25:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A7AB21D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=VPhw/Tqgl35rmCR/EUeanlW74ylD/MHsk9cKjkozgTM=; b=JxA4ErBIoTSNMxH5riOqPybuq6 NOSaT6iHM2wwJyG93+enSs1V1taL520Zskd9CRWS4TasqEDlQvu8oyu7RP1e3M9k98h9LDV8UqdP8 J/ADQSB8iS00llhm9NB0Txx2MuX/OKUdYnOq0337+Ni02UGyYImyjVsJctgDrZl4/0gNHzWEpD8E+ FkW8JTQZ4Q3/siH3KhESuB4I92gP6lPTIMAfT8EoZwsdJou0KaoV/GJDxPH9oTryPcSri5kBQD9JP FcGgGChhwXIXv/08GIENomEejuuwqAj1c4xYrseggAtTualR6Tg1ga1hhH/BNIZk14a+3TqP4nGsu zDYTv3mQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkeHR-0007Qp-AL; Thu, 03 Dec 2020 02:23:37 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkeHI-0007Jj-5n for linux-arm-kernel@lists.infradead.org; Thu, 03 Dec 2020 02:23:29 +0000 Received: by mail-pg1-x542.google.com with SMTP id f17so458471pge.6 for ; Wed, 02 Dec 2020 18:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=iC5H7PO5XwarHvwHYgQh02aF/VfTZGppFy6uziDTw7w=; b=o2piOqAqeFEN+Kh89EyI52c6z1kcipjIKdq5bhLt12B59Q/pE9KBaldV0AXgs9/2Bp RicPLW/Zh3l4dy7diH6cjfSh8lTqHxmENwSZ1YZGfdiCeeviRFNvb1FlJzN7UM7Ke2/b eui9e0FoNRpTbHbUYkMmFUr5ruUy3jlpoR9f7L6VROra2WryWTuGoRIAyM1auBkDqV8T JP/310cVivIn9pzy//tYJ3xtWJvbmkExENcV7Ox5nPF6ti2ee8K8GNtW+tBgjXlV5bxy 2BMWa6HaPqrXrUlTM3i/58q0DwybBtIPuC0vpiMrvh1Z1jyfTcU9a5n1EXEKVFWydHzI pk3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iC5H7PO5XwarHvwHYgQh02aF/VfTZGppFy6uziDTw7w=; b=ORLXbgeJC/lhusGrXPDLbbjwZpsI1KxD8TbYLzMFedeUEN/0qqVoMgO2y5pE6OXdHi BQzE1wL2NU9bPcTjMEPdXFW1MLoj99AZtSv2oAHqKuY4Z/W+ottE3G+g5GEgGq/GGtmT 7RJdm8tqaUKXWijtX5VMFrnlf/FnVPY7EYb4f/Au2wrdEBzjNv3bk/Bon3S59HLqPFxA 1lw9fgv8aruE9Y7dmSNCg9YOeLpp9ajVlAwsFn/rTXSxPuOL6SWGVg8HiWU/aGuBwGWJ Pqv5dHwLFf7Em8Dt7PMVMMcFC8UKQEk4XTS2cMcG7v95G4IO5bd4ZomGGvA9a9I05+5v 753A== X-Gm-Message-State: AOAM531LlGZrkh4gq45d19O9dONjUchMCVI+MRkGboSqwoeBEK0rVwt7 8tG+5WClAQeT2B+1QifkanLGVmqGzkPmew== X-Google-Smtp-Source: ABdhPJx6oqkSAxxnBm4p583T5sRG0+Qs79KYW92fZ9S+J42e6xydw3/E8pPpPlG65j4kalf3i0fKEw== X-Received: by 2002:a62:fc86:0:b029:19d:9943:c843 with SMTP id e128-20020a62fc860000b029019d9943c843mr881393pfh.71.1606962203029; Wed, 02 Dec 2020 18:23:23 -0800 (PST) Received: from TrapDesktop.lan (astound-69-42-20-103.ca.astound.net. [69.42.20.103]) by smtp.gmail.com with ESMTPSA id b4sm179824pju.33.2020.12.02.18.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 18:23:22 -0800 (PST) From: Rosen Penev To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Date: Wed, 2 Dec 2020 18:23:20 -0800 Message-Id: <20201203022321.19952-1-rosenp@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_212328_291923_56CA88DE X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregory.clement@bootlin.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Split up the pins to match earlier definitions. Allows LEDs to flash properly. Fixes: ced8025b569e ("ARM: dts: armada388-helios4") Signed-off-by: Rosen Penev --- arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts index b3728de3bd3f..5a6af7e83e44 100644 --- a/arch/arm/boot/dts/armada-388-helios4.dts +++ b/arch/arm/boot/dts/armada-388-helios4.dts @@ -70,6 +70,9 @@ system-leds { compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&helios_system_led_pins>; + status-led { label = "helios4:green:status"; gpios = <&gpio0 24 GPIO_ACTIVE_LOW>; @@ -86,6 +89,9 @@ io-leds { compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&helios_io_led_pins>; + sata1-led { label = "helios4:green:ata1"; gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; @@ -286,9 +292,12 @@ "mpp39", "mpp40"; marvell,function = "sd0"; }; - helios_led_pins: helios-led-pins { - marvell,pins = "mpp24", "mpp25", - "mpp49", "mpp50", + helios_system_led_pins: helios-system-led-pins { + marvell,pins = "mpp24", "mpp25"; + marvell,function = "gpio"; + }; + helios_io_led_pins: helios-io-led-pins { + marvell,pins = "mpp49", "mpp50", "mpp52", "mpp53", "mpp54"; marvell,function = "gpio";