From patchwork Sun Dec 6 19:02:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954303 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74462C433FE for ; Sun, 6 Dec 2020 19:04:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38C512310B for ; Sun, 6 Dec 2020 19:04:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38C512310B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OZtNjJHP56aHzituyChBjQtQ3iInGyZpYVdYa1dWRp0=; b=Msjch9nDLuijfXRLdnEKVhkIw UKNvPdAK7XzFd02nqiS2eSDt9NcMxbwfZnGiOHKmOSpdPh/dpodfNptUM6dq7SBABXVFnTTkp5tK0 Bl7kHsBVB5qgO3VHULGCG8i8csk52RCuOtnBMq/D460op2elEiJwR7J5RHw4PVpPSAkModphmbJEl yt48LfqOE0qSdZ8KNEAIwNoBvfv2ZRPBKjH51oTsrFMiqHGceWaubPr0XEe/IZ8yaGcyhXeydB6r4 rMEbYCLrKZSF4TtpmLkyOL0HJRJopJKig8ANMic58sCMPIa2zpGpewOMrGIUqBjK5YmZvmTf18n/B j6Fos3qWA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klzJm-0005Re-8b; Sun, 06 Dec 2020 19:03:34 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klzJK-0005Da-HX for linux-arm-kernel@lists.infradead.org; Sun, 06 Dec 2020 19:03:10 +0000 Received: by mail-lf1-x144.google.com with SMTP id u9so9349144lfm.1 for ; Sun, 06 Dec 2020 11:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UOGcGZuV1pDdyacp1Yj7CCfxSkcEGtk2M7nbhP+rzwQ=; b=W4gYsSCFlMC3r/LTQSkwP0qTVDk1kJpWLdduH1jLyAqllGVDMYSQtNHD4blw1N+er2 BugriDhBiTiR7o1RzujF9NtuuU75bkJ/e1zB98RoTOdqONoDAQjpknt9NtEy0ztGO+Z/ y0S6SzoEbDhGl5nvhjjQi380hT99I/TFRGMDxK0NV7z8+vp1An2ttsBS7tU/dEoHTVJe ImwLOV15MWtZB1Vd6wFU7zHTj1P+UjwUUsxnpSrsz3wDH96Uy4CQSzco7ZyQGkY9zI1F qPX/ubbUWILv3tp4AgxnyahY1Y7CDdN1qyjxUQFsTF7qKlWJ4Mup+ExozfOVk0FioVe8 odMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UOGcGZuV1pDdyacp1Yj7CCfxSkcEGtk2M7nbhP+rzwQ=; b=mS9VkGGyrERmwUj4Zpn+C8WLOtCsT3oY1jXpk4jjuFEKHRJd2cRSN9pqEmheF37hJM kaRGK6UqGmOK0R11qeg66l+fpmznssT6yAo4UbGtUYi8+fcgHhQXc7SYy1Q9ZSYHx8yS 8LHLHBf1IIL0WWTaPuThidsKA/G4WjD3NvU6gd8E/4211WppnFGAqeKGbsrjnvKQ9hFM C6/k7tMSL13Dnyebytxtw9Hc7oIr9dOwpEssE7vR6fd2WDd7oJWONkSSZFCQSKPT5pP2 EFLZJJqXwAb5tHr6S0GBichv1JTb4t2y6uXprg3daJXwdpcf3MK+1IINeSURnsn2I5rf 29IQ== X-Gm-Message-State: AOAM531+bbLY3htIRPKeXDGGpWTbPneM+gtDRtUwM6Fpj50/AHZtbpL1 QgUHPQ5LfwexCUz/rNeHDGA= X-Google-Smtp-Source: ABdhPJxsIP6M5qtkKkVSQDTL6GRkXd2Urg3bP3B6nC0o/in7udaqrBXvv8Nl+MDjf6py3v0d86tqOg== X-Received: by 2002:a05:6512:78f:: with SMTP id x15mr7093698lfr.370.1607281385343; Sun, 06 Dec 2020 11:03:05 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:04 -0800 (PST) From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Subject: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning Date: Sun, 6 Dec 2020 20:02:38 +0100 Message-Id: <20201206190247.1861316-5-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201206_140306_818593_8F752929 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Michal Januszewski , Peter Jones , Sam Ravnborg , Geert Uytterhoeven , Michael Ellerman , Thomas Zimmermann , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix W=1 warning by deleting unused local variable. v2: - Updated subject (Lee) v3: - Return early in case of an error (Thomas) Signed-off-by: Sam Ravnborg Cc: Michal Januszewski Cc: linux-fbdev@vger.kernel.org Cc: Lee Jones Acked-by: Thomas Zimmermann --- drivers/video/fbdev/uvesafb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 6c9cfab39313..4df6772802d7 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task, task->t.regs.eax = 0x4f0a; task->t.regs.ebx = 0x0; err = uvesafb_exec(task); + if (err) + return err; if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) { par->pmi_setpal = par->ypan = 0;