| Message ID | 20201221100632.7197-4-peng.fan@oss.nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | remoteproc: imx_rproc: support iMX8MQ/M | expand |
On Mon 21 Dec 04:06 CST 2020, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > > V4: > Drop the R-b tag > Follow Bjorn's comments, correct/update the err msg. > > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6603e00bb6f4..fab772b02c9f 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 >
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 6603e00bb6f4..fab772b02c9f 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, att->sa, att->size); if (!priv->mem[b].cpu_addr) { - dev_err(dev, "devm_ioremap_resource failed\n"); + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); return -ENOMEM; } priv->mem[b].sys_addr = att->sa; @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); if (IS_ERR(priv->mem[b].cpu_addr)) { - dev_err(dev, "devm_ioremap_resource failed\n"); + dev_err(dev, "failed to remap %pr\n", &res); err = PTR_ERR(priv->mem[b].cpu_addr); return err; }