diff mbox series

clk: imx: fix Kconfig warning for i.MX SCU clk

Message ID 20201230155244.981757-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series clk: imx: fix Kconfig warning for i.MX SCU clk | expand

Commit Message

Arnd Bergmann Dec. 30, 2020, 3:52 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

A previous patch introduced a harmless randconfig warning:

WARNING: unmet direct dependencies detected for MXC_CLK_SCU
  Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
  Selected by [m]:
  - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]

Since the symbol is now hidden and only selected by other symbols,
just remove the dependencies and require the other drivers to
get it right.

Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/imx/Kconfig | 2 --
 1 file changed, 2 deletions(-)

Comments

Shawn Guo Jan. 11, 2021, 1:41 a.m. UTC | #1 
On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A previous patch introduced a harmless randconfig warning:
> 
> WARNING: unmet direct dependencies detected for MXC_CLK_SCU
>   Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
>   Selected by [m]:
>   - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> 
> Since the symbol is now hidden and only selected by other symbols,
> just remove the dependencies and require the other drivers to
> get it right.
> 
> Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
> Reported-by: Anders Roxell <anders.roxell@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good to me.

Stephen, I assume that you will pick it up as a material for 5.11-rc.

Shawn
Stephen Boyd Jan. 12, 2021, 7:26 p.m. UTC | #2 
Quoting Shawn Guo (2021-01-10 17:41:11)
> On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > A previous patch introduced a harmless randconfig warning:
> > 
> > WARNING: unmet direct dependencies detected for MXC_CLK_SCU
> >   Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> >   Selected by [m]:
> >   - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
> > 
> > Since the symbol is now hidden and only selected by other symbols,
> > just remove the dependencies and require the other drivers to
> > get it right.
> > 
> > Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")
> > Reported-by: Anders Roxell <anders.roxell@linaro.org>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks good to me.
> 
> Stephen, I assume that you will pick it up as a material for 5.11-rc.
> 

Sure. Applied to clk-fixes.
diff mbox series

Patch

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index 3061896503f3..47d9ec3abd2f 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -6,8 +6,6 @@  config MXC_CLK
 
 config MXC_CLK_SCU
 	tristate
-	depends on ARCH_MXC
-	depends on IMX_SCU && HAVE_ARM_SMCCC
 
 config CLK_IMX1
 	def_bool SOC_IMX1