From patchwork Tue Jan 12 08:53:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Menglong Dong X-Patchwork-Id: 12012801 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0479CC433E0 for ; Tue, 12 Jan 2021 08:54:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB0F9208E4 for ; Tue, 12 Jan 2021 08:54:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB0F9208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XusKfvK5q52AA6gCXBXiVFHptDchdk2DG3jCxWJrkYo=; b=Jp6mDUaJhHB4miQ1PRonmFdNfO TALbUcwezWmt+8qwKFyCgHLYur7GsaezTmAuW05KD24zZ1TkxiuGa6D0ADhRkCgm7jGnXvUG7dWVQ 7BWTg5ntbIK16PZ+cwgYodNjK/xllTQevGdZDZ0Ckuzhz/RTEKMoNVBxrPCwd+C8OsI24uLfm0eHg hblu+nEJvuFHwbn9BwibXb2wHq4UEUGXn4oNjDNN7I5kNCNbW3QCrLdxf2BQlgMUd4LlV5oXbmEfH p0CenExv3pWsNfn1Siun3XDBBBKHSh4szJ2S6SdZxZpxZr6Sv3X6GWUeA7gWpy+3gsJlkK2mQVQht Z8EXiiqw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzFQc-0003yG-0f; Tue, 12 Jan 2021 08:53:26 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzFQY-0003vi-Db for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 08:53:23 +0000 Received: by mail-pg1-x543.google.com with SMTP id v19so978065pgj.12 for ; Tue, 12 Jan 2021 00:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=iCD56C5pg1d1NTNumNDFp4t2vfpUV33Zv3uz34vtHcM=; b=cgvc90vIzF3OIyMlOfnqqxO/AsGLIEc5lSv8L3t2RrsXjaJSpeCOzyADwRMLDX80mh XpILvChB1UGanSwSh6JXbZ8EScoCziyl+K42gASbMI+uL3K0M5xenZza2PmsE8rxiewr RmrdDkT78NsO6+6ElPSNuO05ompOuvhNXk0PiqqbSUs27UsWrZIvvWL1WFTD5Es//tkj /REpahA1UzM1SenWXb0wydnkdyTr1V3jNmT/sK4JbxNp5RolCN6t4fWA8PWmch0bwevM 5Pm0JULrnTj4LU7tpifvD5+Yq4FbhTHKF9P8iL02bH7IJIP8r55DIomBY10uwBILvvXi YBOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iCD56C5pg1d1NTNumNDFp4t2vfpUV33Zv3uz34vtHcM=; b=UAPollMICgLBl+tNQ5k1G3fd7qiOdL75IEfyJk/a0Maw+k/Nd7GHPu4jgpUnOOhuno 1QA1qUeuckP/meUfOTBqbzhJDHD9/udJJ1BV9twwffmDCpq4k6tjVEQ5xDn2gmw1uoSl FpoeQs6U7CbQkfLvwQ3J0P8W1t7q69eiIhmOMs9Mi2yaduqUq+gW7tfneMQe8JWkGa8C xgZva9ExdgRxx0zR7uMlu4VZ3IVax4IrDitO45VRH6rHptfZzxPIjVyRpVrX9TsIyIsr U2Pnk7tmaSbCL0b8Q2r88Dxy18gWqfAMBN0jJW5Xl1Mtiq32mVEMw6EDfT8HedX8GM80 Y5rw== X-Gm-Message-State: AOAM533WgwuxQG4JB+EocDI/8yC5D225IYXxc7NTHv3Urdi8Y/UzQmgw 5xyuFyUInFbfgl8pAKi2FzY= X-Google-Smtp-Source: ABdhPJwWcJw4BGKctgBn3fXpdsTZXyGdlSBNAKK3KdVpgrKCr7T/XRv51DVD9EnvtC9WsP84zj53Ww== X-Received: by 2002:a63:d246:: with SMTP id t6mr3727099pgi.283.1610441598288; Tue, 12 Jan 2021 00:53:18 -0800 (PST) Received: from localhost.localdomain ([178.236.46.205]) by smtp.gmail.com with ESMTPSA id 198sm2392803pfw.29.2021.01.12.00.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 00:53:17 -0800 (PST) From: menglong8.dong@gmail.com X-Google-Original-From: dong.menglong@zte.com.cn To: pierre-yves.mordret@st.com Subject: [PATCH] i2c: remove redundant error print in stm32f7_i2c_probe Date: Tue, 12 Jan 2021 00:53:11 -0800 Message-Id: <20210112085311.7308-1-dong.menglong@zte.com.cn> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_035322_492621_F8FEF722 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Menglong Dong , alexandre.torgue@st.com, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, mcoquelin.stm32@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Menglong Dong Coccinelle reports a redundant error print in stm32f7_i2c_probe. As 'platform_get_irq' already prints the error message, error print here is redundant and can be removed. Signed-off-by: Menglong Dong --- drivers/i2c/busses/i2c-stm32f7.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 9aa8e65b511e..adba496e1e31 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -2026,12 +2026,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) } irq_error = platform_get_irq(pdev, 1); - if (irq_error <= 0) { - if (irq_error != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to get IRQ error: %d\n", - irq_error); + if (irq_error <= 0) return irq_error ? : -ENOENT; - } i2c_dev->wakeup_src = of_property_read_bool(pdev->dev.of_node, "wakeup-source");