From patchwork Mon Jan 18 21:19:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12028289 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05694C433E0 for ; Mon, 18 Jan 2021 21:21:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DAFA22D6E for ; Mon, 18 Jan 2021 21:21:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DAFA22D6E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=lD1ZPMJjDc6vUQKw20ixtiF+Xi0QwxUSBrwSPssrZIM=; b=f1Mbd9FVXYs9WzWnf7Pk9Z6xTk xJBFvs/rnisTyPfs3sDq/g8Mncafor4W7OIfAJHJ8daEnOWevDBGZ9PC50jsq2n5BwO7xCPe6V90r cOmeuGSqdhhAVBMylgXw5h5ZzMjsgzyHjG1vf/LgX7G0t5MIWXAlXQU0db6RUL4O1u2gZJPeclyr8 uHxr6Y0RcqdNU6Lm1dS2nOKd8sVueC2GHH2euTYGZixeTBsLlShbR51U0MHZZWMDKQ2LbMbj1NaEd sYArau5pQVh5orLm/FLT2B3f7kNL2ftHOJQlrRLj8odWHfbODRZ2buXWdGrSdka2JlHz37xt5NePx /nd9H3tA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1bwY-0005IQ-FN; Mon, 18 Jan 2021 21:20:10 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1bwV-0005Hr-Lf for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 21:20:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611004807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dnnhtVflN2ojM9kAenMCIB7Y4XJh/WZ4WZYOBwFIU+E=; b=RYxjVH8oAjNydLM79wYBAXaya/XCmZ5HujKhMfzsG/EQlrxETfzEvjmMif8GmnSJuNYaP5 p0xJGjB/4e8c1rDUGLU9iad+3hD6uI86L9/v/F0gSOTp7izTcoZyYAz+tJKO5Y7SdLe9pz 8THbVqKKqrhb9YaTQtp9TXqVDhCM/D8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-Z35efxFuPbKwEOrgghGD1Q-1; Mon, 18 Jan 2021 16:20:02 -0500 X-MC-Unique: Z35efxFuPbKwEOrgghGD1Q-1 Received: by mail-qk1-f197.google.com with SMTP id g26so18172330qkk.13 for ; Mon, 18 Jan 2021 13:20:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dnnhtVflN2ojM9kAenMCIB7Y4XJh/WZ4WZYOBwFIU+E=; b=l9DDNtQgKLQKyYEKI/iPXDkd9u489WCNPRmOHoKdmIyvCNIx0kz4TpZHUu2J+1qnpU qsZGb5acjwnfrG1anHaQVyHAVwEd0vrvPU0pggVx5xoUxlkMKCH+hECljacRAzzezw4w WRHT2W7c6adhD+YyEDQe/5dIXAK4S5WveLmMN801etLaI6JEryE48mhbWxvwIONl0+bQ 4HhC58qTTJMm5fqiGxJ5UCvtoJ3lzW0deLueSCl4hXKxZyOPLol9fEmw8oJZFStNnibd VHYlp4nW8tizzp9d+SMXSmlsyug0nyf2MDngJQKRbVsp9BNhdGrX+QtNlnqM6UOti1he NhnA== X-Gm-Message-State: AOAM53018FMprj1HL+aQ/XT35cnHQTgc2ym4JzjQOKuFLfmJGhBUXFYZ KzD1VcNm3tgbhKvb+gPprEPGScMLt/o61aL+3rtmTgcLdPUEo1NjO1nIa+mExhYLS3/5eF3770k VVa0Qi85YZcnS3OBMdPMYJ7pZ+MZR63B860k= X-Received: by 2002:a37:c49:: with SMTP id 70mr1486846qkm.365.1611004802175; Mon, 18 Jan 2021 13:20:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzte4H9mRqboR6tvo97B8zSYHvEzDIzcKIOMw+wkTZvDCOqn4qqBKdtPpcbud8KDlh6nVhWJg== X-Received: by 2002:a37:c49:: with SMTP id 70mr1486822qkm.365.1611004801903; Mon, 18 Jan 2021 13:20:01 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id q20sm11484209qkj.49.2021.01.18.13.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 13:20:01 -0800 (PST) From: trix@redhat.com To: daniel.lezcano@linaro.org, tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, viresh.kumar@linaro.org Subject: [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined Date: Mon, 18 Jan 2021 13:19:55 -0800 Message-Id: <20210118211955.763609-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_162007_782938_4E13A0DC X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Rix , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tom Rix When DEBUG is defined this error occurs drivers/clocksource/mxs_timer.c:138:1: error: expected ‘;’ before ‘}’ token The preceding statement needs a semicolon. Replace pr_info() with pr_debug() and remove the unneeded ifdef. Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface") Signed-off-by: Tom Rix --- v1: replace pr_info() with pr_debug() --- drivers/clocksource/mxs_timer.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c index bc96a4cbf26c..e52e12d27d2a 100644 --- a/drivers/clocksource/mxs_timer.c +++ b/drivers/clocksource/mxs_timer.c @@ -131,10 +131,7 @@ static void mxs_irq_clear(char *state) /* Clear pending interrupt */ timrot_irq_acknowledge(); - -#ifdef DEBUG - pr_info("%s: changing mode to %s\n", __func__, state) -#endif /* DEBUG */ + pr_debug("%s: changing mode to %s\n", __func__, state); } static int mxs_shutdown(struct clock_event_device *evt)