| Message ID | 20210121061141.23062-7-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | devicetree fixes for Protonic and Plymovent boards | expand |
Hi Oleksij, On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > At some point PWM cell count was changed, but it didn't triggered any It changed in this commit: commit fa28d8212ede9c533ae87a737571a9d3b3eebb29 Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Date: Fri Jul 10 07:19:37 2020 +0200 ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files The imx-pwm driver supports 3 cells and this is the more flexible setting. So use it by default and overwrite it back to two for the files that reference the PWMs with just 2 cells to minimize changes. This allows to drop explicit setting to 3 cells for the boards that already depend on this. The boards that are now using 2 cells explicitly can be converted to 3 individually. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
On Thu, Jan 21, 2021 at 11:17:42AM -0300, Fabio Estevam wrote: > Hi Oleksij, > > On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > > > At some point PWM cell count was changed, but it didn't triggered any > > It changed in this commit: > > commit fa28d8212ede9c533ae87a737571a9d3b3eebb29 > Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Date: Fri Jul 10 07:19:37 2020 +0200 > > ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files > > The imx-pwm driver supports 3 cells and this is the more flexible setting. > So use it by default and overwrite it back to two for the files that > reference the PWMs with just 2 cells to minimize changes. > > This allows to drop explicit setting to 3 cells for the boards that already > depend on this. The boards that are now using 2 cells explicitly can be > converted to 3 individually. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Shawn Guo <shawnguo@kernel.org> OK, nice. Thx! Should I resend this series without this patch? Regards, Oleksij
diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts index 8a1491975da8..83b461eb33a2 100644 --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts @@ -21,7 +21,7 @@ memory@10000000 { backlight_lcd: backlight-lcd { compatible = "pwm-backlight"; - pwms = <&pwm1 0 500000>; + pwms = <&pwm1 0 500000 0>; brightness-levels = <0 20 81 248 1000>; default-brightness-level = <20>; num-interpolated-steps = <21>; @@ -320,7 +320,6 @@ &ipu1_di0_disp0 { }; &pwm1 { - #pwm-cells = <2>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pwm1>; status = "okay";
At some point PWM cell count was changed, but it didn't triggered any error, since this DT was overwriting "#pwm-cells". To make sure, we are in sync with the kernel driver, remove this property and fix the pwm consumer. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)