Message ID | 20210126124540.3320214-22-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Rid W=1 warnings from Clock | expand |
On 1/26/21 1:45 PM, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/clk/zynqmp/divider.c:46: warning: Function parameter or member 'max_div' not described in 'zynqmp_clk_divider' > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: Rajan Vaja <rajan.vaja@xilinx.com> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/clk/zynqmp/divider.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c > index 66da02b83d393..e9bf7958b8218 100644 > --- a/drivers/clk/zynqmp/divider.c > +++ b/drivers/clk/zynqmp/divider.c > @@ -35,6 +35,7 @@ > * @is_frac: The divider is a fractional divider > * @clk_id: Id of clock > * @div_type: divisor type (TYPE_DIV1 or TYPE_DIV2) > + * @max_div: maximum supported divisor (fetched from firmware) > */ > struct zynqmp_clk_divider { > struct clk_hw hw; > In our soc tree we have * @max_div: Maximum divisor value allowed But your description should be also fine. Rajan please reply if I am wrong. Otherwise: Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
Quoting Lee Jones (2021-01-26 04:45:40) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/zynqmp/divider.c:46: warning: Function parameter or member 'max_div' not described in 'zynqmp_clk_divider' > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: Rajan Vaja <rajan.vaja@xilinx.com> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Applied to clk-next
diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c index 66da02b83d393..e9bf7958b8218 100644 --- a/drivers/clk/zynqmp/divider.c +++ b/drivers/clk/zynqmp/divider.c @@ -35,6 +35,7 @@ * @is_frac: The divider is a fractional divider * @clk_id: Id of clock * @div_type: divisor type (TYPE_DIV1 or TYPE_DIV2) + * @max_div: maximum supported divisor (fetched from firmware) */ struct zynqmp_clk_divider { struct clk_hw hw;
Fixes the following W=1 kernel build warning(s): drivers/clk/zynqmp/divider.c:46: warning: Function parameter or member 'max_div' not described in 'zynqmp_clk_divider' Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Michal Simek <michal.simek@xilinx.com> Cc: Rajan Vaja <rajan.vaja@xilinx.com> Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/clk/zynqmp/divider.c | 1 + 1 file changed, 1 insertion(+)