| Message ID | 20210209125912.3398-3-nsaenzjulienne@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Raspberry PI 4 V3D enablement | expand |
On Tue, Feb 09, 2021 at 01:58:58PM +0100, Nicolas Saenz Julienne wrote: > Anticipating the introduction of BCM2711, of which we'll need to support > its new Argon ASB, introduce reg-names into bcm2835-pm's binding. This > will help to have a consistent mapping between resources and their > meaning. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- > .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > index 8bc65e5f62a7..1dbe3657c690 100644 > --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml > @@ -26,8 +26,13 @@ properties: > reg: > minItems: 1 > maxItems: 2 > - description: Specifies base physical address and size of the two register > - ranges, "PM" and "ASYNC_BRIDGE" in that order. Ah, it's okay this way if you have -names. Or have items to give a bit more detail. > + > + reg-names: > + minItems: 1 > + maxItems: 2 > + items: > + - const: pm > + - const: rpivid_asb Not really clear how this corresponds to 'ASYNC_BRIDGE'. 'asb' I guess? > > "#power-domain-cells": > const: 1 > @@ -54,6 +59,7 @@ properties: > required: > - compatible > - reg > + - reg-names You can't really make added properties required. > - "#power-domain-cells" > - "#reset-cells" > - clocks > @@ -70,6 +76,7 @@ examples: > #reset-cells = <1>; > reg = <0x7e100000 0x114>, > <0x7e00a000 0x24>; > + reg-names = "pm", "rpivid_asb"; > clocks = <&clocks BCM2835_CLOCK_V3D>, > <&clocks BCM2835_CLOCK_PERI_IMAGE>, > <&clocks BCM2835_CLOCK_H264>, > -- > 2.30.0 >
diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml index 8bc65e5f62a7..1dbe3657c690 100644 --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml @@ -26,8 +26,13 @@ properties: reg: minItems: 1 maxItems: 2 - description: Specifies base physical address and size of the two register - ranges, "PM" and "ASYNC_BRIDGE" in that order. + + reg-names: + minItems: 1 + maxItems: 2 + items: + - const: pm + - const: rpivid_asb "#power-domain-cells": const: 1 @@ -54,6 +59,7 @@ properties: required: - compatible - reg + - reg-names - "#power-domain-cells" - "#reset-cells" - clocks @@ -70,6 +76,7 @@ examples: #reset-cells = <1>; reg = <0x7e100000 0x114>, <0x7e00a000 0x24>; + reg-names = "pm", "rpivid_asb"; clocks = <&clocks BCM2835_CLOCK_V3D>, <&clocks BCM2835_CLOCK_PERI_IMAGE>, <&clocks BCM2835_CLOCK_H264>,
Anticipating the introduction of BCM2711, of which we'll need to support its new Argon ASB, introduce reg-names into bcm2835-pm's binding. This will help to have a consistent mapping between resources and their meaning. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- .../devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)