From patchwork Fri Mar 5 09:48:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 12118173 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35764C433DB for ; Fri, 5 Mar 2021 09:50:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEC9364FE9 for ; Fri, 5 Mar 2021 09:50:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEC9364FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=tJ7AuPfcHO4Damimuf11KW6+jyOwFmbByZDp6z3E0QM=; b=DqYq7erpkQp/XqSAtCfa1kk5ym KyjwlJ5JG10agY4ogcBbCRnWEG+8xLx6uui9eU9PRT+8bMl7cr7eKejM0QQR+uhFQ3bMzfgW9a40t GcOxZLT80K/bAaWb1jc7ICjKWPveTud93tZZbIGZ5zN4MD9Gjs28al+4H2bhVjW9NI/oUf3/KpT8D AQmc3o4OmBZUvOLXN7dZTLzXTyXX7hWq/dN+oXReO9pn8S0KQeBHCmghYFe0FgGKN3wg0OlnYC8Wc JVGf8Lq7gTDGUpu8IKMtc808m471XQ0tMVxzrIecjBKetmPbEkEYCu5+mNSzj1yp+57GcjkyMu9Vb z3ZiNnDw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI74T-00EMmL-QN; Fri, 05 Mar 2021 09:48:34 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI74N-00EMkH-MX for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 09:48:29 +0000 Received: by mail-pf1-x432.google.com with SMTP id q204so1641818pfq.10 for ; Fri, 05 Mar 2021 01:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=lBLqTm8LAm2vM2JvWYN/kau0Luv/b/q3A2F/WW9Z07Y=; b=qH4Uj+KOv9z9Z308T8ARccdkgubmvLPUjafgS7q2F5DZgM6dlgF0He+hq9m6gHsR4n oMHrtH21C32CLqJg0wlgzcct7a9OKZ8RG/a2fMYZChDff1Ye38VIhZazIOiC/MUQ6WaD 55OrRrrfsKWyITLr1LVY2geVsCPxH4G9kw3i1qU8xUP/I2wVVS4fDzkrJHLXlrI6uXND iKTY8ZfjfXbcWjkJvbUbU2Cd7M5kegq3FjDoA3vQSlxpN5O75nYOVwI7omxFNbj0Or4V F4FvyVMhDX1BN5ujTzJDWYrM7H/3156TuzoZHEPKE102J5XU/cj6koGgmnEc9+cDD+ju 83Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lBLqTm8LAm2vM2JvWYN/kau0Luv/b/q3A2F/WW9Z07Y=; b=AZt9rZwQb5S/fhbVG17DG5WQKhxfSIV3IngWXGMvCWtI2EnLkp70iZGcJ/whSjnpxB 4zSiU5N617qCdioHIMiS+OJtboiYIcPJTSlNjMDzO+qfwj0Z4cm64ZhmjAhQFP7rdGro NA2d1qV6nPS/CmBjhJe7tjGpiSRb/mH5rhibuoAswROBXYnjoj+K0YF5kjzgs3TSZsAG x4j//tThl6887ByEzyPyP4M+B0yUNkU4sPXT3tUjTESZv5anaOppKEZRODmMIr4rvEkK OxXacArC+10mtE8P7rkouOvifLDrkh1LJQvN7JTzBDOpIGnRanXkeHPoX4KK+htv9aSE XQAQ== X-Gm-Message-State: AOAM533VvMlnmUHdYgBjjt2pmOaR9CRNWzJg5qEsdt0ZVUedTeXMFyDL hnrS80IYVWy0guxsrfORNYs= X-Google-Smtp-Source: ABdhPJyvbZcUBXp9Ww2TB7V8o1nujwy2gTBBkcI9x0R6Hvx7mBzQi89MX8pZmA96J57Jm1wA9FEfvA== X-Received: by 2002:a05:6a00:ac8:b029:1ed:f8dc:cb3b with SMTP id c8-20020a056a000ac8b02901edf8dccb3bmr7948223pfl.60.1614937706258; Fri, 05 Mar 2021 01:48:26 -0800 (PST) Received: from localhost.localdomain ([45.135.186.129]) by smtp.gmail.com with ESMTPSA id x1sm1727420pje.40.2021.03.05.01.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 01:48:25 -0800 (PST) From: Jia-Ju Bai To: hyun.kwon@xilinx.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, michal.simek@xilinx.com Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] media: platform: xilinx: fix error return code of xvip_graph_init() Date: Fri, 5 Mar 2021 01:48:19 -0800 Message-Id: <20210305094819.13685-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_094828_439975_F32A884D X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When the list of xdev->notifier.asd_list is empty, no error return code of xvip_graph_init() is assigned. To fix this bug, ret is assigned with -ENOENT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Reviewed-by: Michal Simek --- drivers/media/platform/xilinx/xilinx-vipp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index bf4015d852e3..2ce31d7ce1a6 100644 --- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev) if (list_empty(&xdev->notifier.asd_list)) { dev_err(xdev->dev, "no subdev found in graph\n"); + ret = -ENOENT; goto done; }