Message ID | 20210305100759.14500-1-baijiaju1990@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=fJxK=ID=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF04C433DB for <linux-arm-kernel@archiver.kernel.org>; Fri, 5 Mar 2021 10:11:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C8C165032 for <linux-arm-kernel@archiver.kernel.org>; Fri, 5 Mar 2021 10:11:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C8C165032 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=00rFqlyP/6KTA9g9akQ0tHv5nV3f1Pz4CftGMSys+QI=; b=ONBSee35FhgvXy/lOWT6m7Kh8P fiWgblKH604d/ut4gqvia6PCZawBU3gdu6WoC0oGaQm8r7OA1Zb/KYwMn/YRO60x8/v54AElNbP8p d3M/5yavtV4p4XXiqTvHaK0Chbk9zaMM7pPWrYKrY8wumqnlPgskb/Xaq5eft5jr7Hy9JOAwKm1+2 ex8WBeKhvtIKqUnehG8zeQovZsqZ9zUleAlrjK8oQrUktVLmcbqMvsxqAXy5LE5sIogzCFzHNP1DM ikIlNwPWNVzifYPH9YB+jvtiWjp6aGw/gy0DVoVLvEQQ7rjU7A/Tzqv9nOF/fd9IqqVEoc8fbRlDc BdOAmrLw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI7O8-00ES9G-4r; Fri, 05 Mar 2021 10:08:55 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI7Nd-00ES0T-PK for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:08:25 +0000 Received: by mail-pf1-x42f.google.com with SMTP id 16so274523pfn.5 for <linux-arm-kernel@lists.infradead.org>; Fri, 05 Mar 2021 02:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=FaAijpHPImNv0WD5I90hcG5zei5rslAfFjyFTmWsex0=; b=VBmc0tfANQgzpVv05QM+6UYYd8SeCk5aJBZ4A/6123VzWZX0ul2hiNd8E4/wvYUI3u 0WuD+IxtkcDBySqwPg6BXL1jZC0nOpvrsrOwM2Qr7LZQmy1ky0LQrz00R7hL8zE2CR3A PqWifwgEnIrxE+CS8v2n3hsziRd1rxL9Aiwll4PcxOEts76DJTDy9uZB86A8qV/BFi7q TPy1UuY1ElxOh3YJBwlKagKVwVJAPWBSzvmMlzYorqieAHgfOh51qoCVAWhLybDDNaWO AqzqM1JfmZuC/XTNCsmupetGaX+hvAirKsbVrHSjjOZQ8SxdGiXs0TrOpSN7UAbVPtB0 d9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FaAijpHPImNv0WD5I90hcG5zei5rslAfFjyFTmWsex0=; b=IDn92OElHkyLshtAlpGL0EGAeekIoGp4OBBlncJehqLAX4cbGn4AkEv9gMvMLXD5wF 9pXWrOUu1h4I6jZR+jCj6WowSSGr1XAEySBe+WXrM3nm0qjeuaJZazU/qFwKa+huZ+SU ALyQm24vkSCZx+hf+8TKapKnXi+L8ip78iwI5/8sF2mJA1H6Y7By6WOtQPoCLHFPPvB3 VaXPjDCXp5u8ggEhBTETw5XN8YCaa8qCUoRc3dwQ490FzD4TuVtQxnWt2bHovjMed2e8 1s6qy3MWqTowOAyPt0tKm9yq7IQw4gfAiva26IQ9/pSL+j9LNG56qhN7QenmKRwkNHp1 7iDA== X-Gm-Message-State: AOAM53141sWICPTGUSGcS2Qz9z43oa/LH+Vptz6T7RUxEP/+WKe+jGRF hJC6PasHui28bSH7OGUC0kk= X-Google-Smtp-Source: ABdhPJx4UlLJ5AkOXamjUfQze5idZeGQHUqNnDBvGz228s1sf28UxFaM8BMWlmt+bJrtYUny4pu7pQ== X-Received: by 2002:a63:170e:: with SMTP id x14mr7847290pgl.245.1614938899393; Fri, 05 Mar 2021 02:08:19 -0800 (PST) Received: from localhost.localdomain ([45.135.186.129]) by smtp.gmail.com with ESMTPSA id t17sm2134571pgk.25.2021.03.05.02.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 02:08:18 -0800 (PST) From: Jia-Ju Bai <baijiaju1990@gmail.com> To: alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, krzk@kernel.org, kwmad.kim@samsung.com, beanhuo@micron.com, weiyongjun1@huawei.com, stanley.chu@mediatek.com Cc: linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai <baijiaju1990@gmail.com> Subject: [PATCH] scsi: ufs: fix error return code of exynos_ufs_get_clk_info() Date: Fri, 5 Mar 2021 02:07:59 -0800 Message-Id: <20210305100759.14500-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_100823_615948_73A30892 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
scsi: ufs: fix error return code of exynos_ufs_get_clk_info()
|
expand
|
diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index 267943a13a94..d67652e5cc34 100644 --- a/drivers/scsi/ufs/ufs-exynos.c +++ b/drivers/scsi/ufs/ufs-exynos.c @@ -264,8 +264,10 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs *ufs) u8 div = 0; int ret = 0; - if (list_empty(head)) + if (list_empty(head)) { + ret = -ENOENT; goto out; + } list_for_each_entry(clki, head, list) { if (!IS_ERR(clki->clk)) {
When the list of head is empty, no error return code of exynos_ufs_get_clk_info() is assigned. To fix this bug, ret is assigned with -ENOENT as error return code. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> --- drivers/scsi/ufs/ufs-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)