From patchwork Sat Mar 6 14:15:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 12120037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB6EC433E0 for ; Sat, 6 Mar 2021 14:17:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68C6E65004 for ; Sat, 6 Mar 2021 14:17:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68C6E65004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=gdZLTbnvzA64NykUhjGc9CryIRwC12TRaZ9lUC84KXU=; b=qZIy1E9rLsMR2UgtSE3dsKh1Xq n1bPKeEMUJjJPTri+fJPAKFyFXM33HwFp8zzQmx7CfNbGr5H86+NIxL+GgffAHzt6iwaIV5TtQTKK lppAmKcISJs1KWmHi26X49pc+W2ZBVPc63XO0hHbqmM1HwY0Ub+R7Qxxvu5Na6ALANGpT2axN0HDe cGjU5vY676vE22VXyJZUY4KB36k1CFlFQMrWPJFZj56DkkAGbUAa8RLOSQQs+ylp+3qStSX4gfISq sC2c5VDh/F2wVzLpKQQSDYk51J/P80w/waSHmln6EwM0DoClerh5nwLdEka0hsyjclzMHrChVjjDm D98e3F6g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIXig-003F1R-Go; Sat, 06 Mar 2021 14:15:50 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIXib-003F0f-Oj for linux-arm-kernel@lists.infradead.org; Sat, 06 Mar 2021 14:15:47 +0000 Received: by mail-pj1-x1034.google.com with SMTP id q2-20020a17090a2e02b02900bee668844dso674823pjd.3 for ; Sat, 06 Mar 2021 06:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=X8TTCBPkViEllxII2GAPq686qNKT8VhCeBCNCuQb630=; b=X4HjQFXJ5I+4Ga5ghW9W0m+NFQmbaZvOV/98ZlS9tGmLGyTFguBYAqaluWx6xhXs5x +Flxm6eUBr75IEMaL91AqyIrG0WtRsQKeK9WEFTtsywnpiLhd9CCkOQxxetDnNTJr+eH 3z1yvhdANnQdGU+jcpbmOL7qTJOKvuGjQrAp72HicTG7vJVHyI7VIF4w8oQn5Z3UA0wr 2grs5Nhohf7kdBvXkNe7YyFG1hdlnQjW/h9WmqNNxIrLvE44Wdmto/OgVQWeqwNe1fOg hZVJR6PWKGyPL2vth00xb01ROaTnNFPNx1ykVUcZlHJ0DGcq7Uzs3PE7HCqHehn/Sr9U uGAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=X8TTCBPkViEllxII2GAPq686qNKT8VhCeBCNCuQb630=; b=jAO10+lGIxvxojpfOyLx2gICzV2YV7pqTGoTrzz8NvT5AYILXvtBQK7x/jMaftmgOg TIKSx6IMXgOSPr9QIj9xXPlDieZJbIk6TQoPDBX1FiUK5PN31HK/MqYcQX9DgbWywp5W HMcnPRqK2TEfIveFG/BPDznX3JGJllnexomIfizWwqN2E0F+ZSq5OaD0Sij1zn0Z4ECg WFsQjnMotwOqhb15xyYQvUQ/BPlCb7gM8Gm+0mW6aBsxSbTRlIjXEp8cAw2ekE4PrIWc I/HdCtIssXcxYOfwa5tzQq51sdQYI+f+YZAaDb7LTGFP5AOu4mfI8xyKzOXE5YsMwHq7 pHjg== X-Gm-Message-State: AOAM530lR+6m1cARRd+v85IMMZfynH0WN3HyD4T1YDIb8ePwTgKh//er lwhmgbg0v3wVKgdCILX9fpU= X-Google-Smtp-Source: ABdhPJyaM8lMeDzibOR+TiKsLfgOxn28TEFwwtmGxMsh78ukFhJQhsfWsQh0vUQxUgOzuk2qDAxXXQ== X-Received: by 2002:a17:90a:e50c:: with SMTP id t12mr15289117pjy.138.1615040144308; Sat, 06 Mar 2021 06:15:44 -0800 (PST) Received: from localhost.localdomain ([45.135.186.79]) by smtp.gmail.com with ESMTPSA id 64sm5516888pfd.174.2021.03.06.06.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 06:15:43 -0800 (PST) From: Jia-Ju Bai To: yong.deng@magewell.com, mchehab@kernel.org, mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming() Date: Sat, 6 Mar 2021 06:15:28 -0800 Message-Id: <20210306141528.18925-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210306_141546_139538_9BF2D040 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When sun6i_video_remote_subdev() returns NULL to subdev, no error return code of sun6i_video_start_streaming() is assigned. To fix this bug, ret is assigned with -EINVAL in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Acked-by: Chen-Yu Tsai --- drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c index b55de9ab64d8..3181d0781b61 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c @@ -151,8 +151,10 @@ static int sun6i_video_start_streaming(struct vb2_queue *vq, unsigned int count) } subdev = sun6i_video_remote_subdev(video, NULL); - if (!subdev) + if (!subdev) { + ret = -EINVAL; goto stop_media_pipeline; + } config.pixelformat = video->fmt.fmt.pix.pixelformat; config.code = video->mbus_code;