diff mbox series

[v2,1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

Message ID 20210322092651.7381-2-arnaud.pouliquen@foss.st.com (mailing list archive)
State New, archived
Headers show
Series remoteproc: stm32: add support of detaching a remote processor | expand

Commit Message

Arnaud Pouliquen March 22, 2021, 9:26 a.m. UTC
Add the "detach" mailbox item, that allows to define a mailbox to
send a IPCC signal to the remote processor on remoteproc detach action.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
---
update from V1:

Fix indentation error reported by 'make dt_binding_check'.

---
 .../bindings/remoteproc/st,stm32-rproc.yaml           | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comments

Rob Herring March 30, 2021, 2:41 p.m. UTC | #1
On Mon, 22 Mar 2021 10:26:50 +0100, Arnaud Pouliquen wrote:
> Add the "detach" mailbox item, that allows to define a mailbox to
> send a IPCC signal to the remote processor on remoteproc detach action.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
> update from V1:
> 
> Fix indentation error reported by 'make dt_binding_check'.
> 
> ---
>  .../bindings/remoteproc/st,stm32-rproc.yaml           | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Arnaud Pouliquen March 31, 2021, 7:31 a.m. UTC | #2
On 3/30/21 4:41 PM, Rob Herring wrote:
> On Mon, 22 Mar 2021 10:26:50 +0100, Arnaud Pouliquen wrote:
>> Add the "detach" mailbox item, that allows to define a mailbox to
>> send a IPCC signal to the remote processor on remoteproc detach action.
>>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
>> ---
>> update from V1:
>>
>> Fix indentation error reported by 'make dt_binding_check'.
>>
>> ---
>>  .../bindings/remoteproc/st,stm32-rproc.yaml           | 11 +++++++++--
>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

Thank Rob for the review
Since there is already a v3 that fixes the patch 2/2 , i will send a v4 to
include your reviewed-by

Regards,
Arnaud
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
index a1171dfba024..64afdcfb613d 100644
--- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
@@ -65,16 +65,23 @@  properties:
           Unidirectional channel:
             - from local to remote, where ACK from the remote means that it is
               ready for shutdown
+      - description: |
+          A channel (d) used by the local proc to notify the remote proc that it
+          has to stop interprocessor communnication.
+          Unidirectional channel:
+            - from local to remote, where ACK from the remote means that communnication
+              as been stopped on the remote side.
     minItems: 1
-    maxItems: 3
+    maxItems: 4
 
   mbox-names:
     items:
       - const: vq0
       - const: vq1
       - const: shutdown
+      - const: detach
     minItems: 1
-    maxItems: 3
+    maxItems: 4
 
   memory-region:
     description: