| Message ID | 20210401103500.1558058-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] media: camss: csiphy: Remove redundant dev_err call in msm_csiphy_subdev_init() | expand |
Hey Yang, Thanks for the patch, feel free to add my r-b. Reviewed-by: Robert Foss <robert.foss@linaro.org> On Thu, 1 Apr 2021 at 12:33, Yang Yingliang <yangyingliang@huawei.com> wrote: > > There is an error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/media/platform/qcom/camss/camss-csiphy.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c > index 6ceb6d7d53d1..b3c3bf19e522 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c > @@ -593,20 +593,16 @@ int msm_csiphy_subdev_init(struct camss *camss, > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); > csiphy->base = devm_ioremap_resource(dev, r); > - if (IS_ERR(csiphy->base)) { > - dev_err(dev, "could not map memory\n"); > + if (IS_ERR(csiphy->base)) > return PTR_ERR(csiphy->base); > - } > > if (camss->version == CAMSS_8x16 || > camss->version == CAMSS_8x96) { > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, > res->reg[1]); > csiphy->base_clk_mux = devm_ioremap_resource(dev, r); > - if (IS_ERR(csiphy->base_clk_mux)) { > - dev_err(dev, "could not map memory\n"); > + if (IS_ERR(csiphy->base_clk_mux)) > return PTR_ERR(csiphy->base_clk_mux); > - } > } else { > csiphy->base_clk_mux = NULL; > } > -- > 2.25.1 >
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c index 6ceb6d7d53d1..b3c3bf19e522 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -593,20 +593,16 @@ int msm_csiphy_subdev_init(struct camss *camss, r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); csiphy->base = devm_ioremap_resource(dev, r); - if (IS_ERR(csiphy->base)) { - dev_err(dev, "could not map memory\n"); + if (IS_ERR(csiphy->base)) return PTR_ERR(csiphy->base); - } if (camss->version == CAMSS_8x16 || camss->version == CAMSS_8x96) { r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]); csiphy->base_clk_mux = devm_ioremap_resource(dev, r); - if (IS_ERR(csiphy->base_clk_mux)) { - dev_err(dev, "could not map memory\n"); + if (IS_ERR(csiphy->base_clk_mux)) return PTR_ERR(csiphy->base_clk_mux); - } } else { csiphy->base_clk_mux = NULL; }
There is an error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/media/platform/qcom/camss/camss-csiphy.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)