Message ID | 20210410015300.3764485-7-swboyd@chromium.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=jXx7=JH=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BABC433ED for <linux-arm-kernel@archiver.kernel.org>; Sat, 10 Apr 2021 01:57:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 279CA611AD for <linux-arm-kernel@archiver.kernel.org>; Sat, 10 Apr 2021 01:57:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 279CA611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c0IA0NTTdFkuOCc6lnhsE7Z2lWNYeiNwTy8bGRheWX4=; b=nxAgNlM8c+iiBcw/vepFFIMBo PCZerLQ14P1UuzsjDv6U7ycDXKoD68n8gj+DHJOfPZ6QsAEjxEU3eTwMAMNnChT43V4ZngsnW518p DajZPcnHc7G70mXnzFuDOUvvJON2mslXECV4l/mHopWRx6ZJN7kIxw2UJ4e9hktgkCYwc2u79P9xX AjwmzIHurMeV0vj0jxrJWjBSEKuVOwDUagwp7zzNqNsDW/TCTA1gM9QlL0U+KcS9A54i3+q3Hsrpo 5tW6EeN2GBH703wkrS0Y3SqhQ1fil3pZYMMTMNnQ9bgpUTc0CD3ZqEGzlNhz7c+8BvEbuhhwkY2AA PEonPBNfg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV2qt-001v06-DX; Sat, 10 Apr 2021 01:56:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV2oA-001uoi-G3 for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 01:54:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=FyaqEBUsrNU4wdW5auqsCPRj45 D40grHR8r5B8VOIu71hebTYTzOCluyqhUa/DMNp1p/fhQl3Gcu2TR0gSgqcvLJDPA8esbxVXrbqwT /k4a5WIGDOSVE8dCeZ6RtV1ADUtWeK0yBEXooZLH0J9e6IEK4sQZF+kKFet3FTiZAouneoxVoRJbU 1a98bLkSTiZgWog6j5lhhZI4zrM0FubVxv8N1r3dXMcQgFW4JjrDhjNkOZ42VrP1lsCq7DBKmJEmz zbs4zs7NK7S+PvqiJL5wz9OHYLkvAjATtcMNNi1flc8wBgPGymp3NYXElWuI/NivUc7a04thMaYu7 8T5PQwoQ==; Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV2o7-004twA-Qc for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 01:53:09 +0000 Received: by mail-pf1-x42c.google.com with SMTP id a85so4945226pfa.0 for <linux-arm-kernel@lists.infradead.org>; Fri, 09 Apr 2021 18:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=TP/ej0A5oIbB+SZtsRxku6ynn0XFhltYZbU946pbzvENIPryBryzlCL8OsXZPO5/39 5wp3q/GEB1X8Vec131bV1WM0mwViEIKK3qoyRIirnHyTnuEvIpGVUefSgMxW8FVaiD9H IDhSM2hT9uM40D9RHJWn5U6LOvPEUXG0EI1M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=dIV9uMRo2bsxgmRuyuBekwh/yamltShOTUvSkWg3YEJ2Y2XtrkqZN4o+mLAC/GdT3O oIywT46kPwZYfgHN5Z8CSFVnuKpaMV+Xvpb3MDH05KcPwW9aChfWQIDRP4uC5lHcDDFu eMeL8xd0kQlMAnZmM4y5FA3YI4aupteRGljCH9FaiVu05p1yFD/WbCXlY04V7lYoxP/m i8HQUfyFA4+0/YW9h4sCigw2Ik8VBkZVEr5Qtwvwk/pwpE1n0HxtYABUfbiV6IOMUTB/ 1uAWso4c77mck++X0jv8rlGhwlkouF8kXIojwIQoimso6ffSJwE3I/sfIPPbsijQFOXk 53oQ== X-Gm-Message-State: AOAM531Cl2nA6/e+vZINzRkAX7v3pKSMmZM2A05vH9jtXpEHzu11eA50 ryhnAl9FJdT0OKwB0sb+5BUbSQ== X-Google-Smtp-Source: ABdhPJw8ZEAEA342lhXIwD1tc1lC/gFPTrsFOOLwwizGLOeyoEtQpg+N0r26bdjfaqGjN5mMFbargw== X-Received: by 2002:a63:1820:: with SMTP id y32mr15990639pgl.157.1618019587023; Fri, 09 Apr 2021 18:53:07 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5141:7881:7013:743b]) by smtp.gmail.com with ESMTPSA id n23sm3837962pgl.49.2021.04.09.18.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 18:53:06 -0700 (PDT) From: Stephen Boyd <swboyd@chromium.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>, Evan Green <evgreen@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Petr Mladek <pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Matthew Wilcox <willy@infradead.org> Subject: [PATCH v4 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Fri, 9 Apr 2021 18:52:53 -0700 Message-Id: <20210410015300.3764485-7-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog In-Reply-To: <20210410015300.3764485-1-swboyd@chromium.org> References: <20210410015300.3764485-1-swboyd@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_185307_879824_F39364A4 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
Add build ID to stacktraces
|
expand
|
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,
Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: <linux-arm-kernel@lists.infradead.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Jessica Yu <jeyu@kernel.org> Cc: Evan Green <evgreen@chromium.org> Cc: Hsin-Yi Wang <hsinyi@chromium.org> Cc: Petr Mladek <pmladek@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Matthew Wilcox <willy@infradead.org> Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)